Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stored: fix crashes of storage tools when autoxflate plugin is loaded #1370

Merged
merged 9 commits into from
Feb 7, 2023
Merged

stored: fix crashes of storage tools when autoxflate plugin is loaded #1370

merged 9 commits into from
Feb 7, 2023

Conversation

arogge
Copy link
Member

@arogge arogge commented Feb 3, 2023 •
edited
Loading

Thank you for contributing to the Bareos Project!

Backport of PR #1348 to bareos-21 (remove this line, if it no backport)

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@pstorz @arogge
autoxflate: verify valid compress.deflate_buffer
2f81b6e 
(cherry picked from commit bd9eb37)
@pstorz @arogge
bls.cc: call bSdEventSetupRecordTranslation
ff053c7 
This call lets the autoxflate plugin setup the compression buffers.

(cherry picked from commit 6ebb09f)
@pstorz @arogge
systemtests: run bls,bscan,bextract with autoxflate
18ebf11 
(cherry picked from commit 3b53e94)
@pstorz @arogge
bscan: minimized memleaks
487be87 
(cherry picked from commit 3926f2d)
@pstorz @arogge
bextract, bls; minimized leaks
5692b49 
(cherry picked from commit 463bc4b)
@arogge arogge requested a review from pstorz February 3, 2023 12:27
pstorz
pstorz approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

pstorz and others added 3 commits February 7, 2023 10:45
@pstorz @arogge
bcopy: reduce memleak
6ac2af7 
(cherry picked from commit 6ce2c96)
@arogge
stored: fix leak when reading translated records
e7aff87 
When records are translated by a plugin the plugin will allocate its own
record. In this scenario ReadRecords() is supposed to call FreeRecord()
which it didn't do.

(cherry picked from commit 5874bc4)
@arogge
systemtests: adapt to renamed bareos-basic test
d7f3a07 
(cherry picked from commit b109580)
@arogge arogge force-pushed the dev/pstorz/bareos-21/fix-bls-crash branch from 7921326 to d7f3a07 Compare February 7, 2023 09:46
@arogge arogge merged commit 22a5ac5 into bareos:bareos-21 Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pstorz pstorz pstorz approved these changes

Assignees
No one assigned
Labels
bugfix is a backport to 21
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arogge @pstorz