Don't use ephemeral ports for test servers #856

arogge · 2021-06-17T15:47:55Z

This PR changes systemtests and unittests to bind their servers only to ports smaller than 32768, so we cannot run into conflicts with ephemeral (i.e. client application) ports during testing anymore.

Please check

Short description and the purpose of this PR is present above this paragraph
Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General

PR name is meaningful
Purpose of the PR is understood
Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
Commit descriptions are understandable and well formatted

Source code quality

Source code changes are understandable
Variable and function names are meaningful
Code comments are correct (logically and spelling)
Required documentation changes are present and part of the PR
bareos-check-sources --since-merge does not report any problems
git status should not report modifications in the source tree after building and testing

previusly these were run on high port numbers what might lead to conflicts.

Previusly, 42001 was used which could potentially lead to conflicts, as Linux uses everything above 32768 as an ephemeral port.

bbb27a5ef Merge pull request bareos#873 from Cyan4973/dev 72e69d33c fix speed improvement line c8060b467 Merge pull request bareos#871 from Cyan4973/revert_17to128 d50741404 Merge pull request bareos#872 from t-mat/dev 21804396b revert XXH3's 17to128 variant to single accumulator 2352ef1bd CI: Add gcc-13 and clang-{13,14,15} d58915966 Merge pull request bareos#869 from t-mat/fix/hide-x86-dispatcher-internals 557799a5b Merge pull request bareos#868 from t-mat/fix/hide-internal-macros 7031f87b8 fix: hide x86 dispatcher internals from document 4b93d0afb add: introduce "public" and "internal" Doxyfile 9e1cf4e6d Merge pull request bareos#867 from t-mat/fix/intel-compiler-assert 0f31a5f38 Add missing '!' 97be68d73 fix: hide internal macros from doxygen ee51543f8 fix: Intel compiler's warning for XXH_ASSERT() a11238549 Merge pull request bareos#866 from t-mat/fix/vc2022-clang-cl 8b093f2d7 fix: enable clang-cl test for VC++2022 0c8e930f8 Merge pull request bareos#863 from Cyan4973/visual_clang_dispatch_test a8ded1869 add a test combining Windows + Visual + Clang-Cl + DISPATCH=1 1a53004d8 Merge pull request bareos#865 from t-mat/fix/clang-cl-dispatch d82321b71 fix: support clang-cl and dispatch 1e5c0f56b fix: support clang-cl f5cbcb8da Merge pull request bareos#864 from t-mat/fix/clang-cl-sign-warning 595341936 fix: __cpuidex pointer type warning 4fd75d7bd Merge pull request bareos#860 from Cyan4973/old_names_warning b20311018 added a compilation warning message for XXH_OLD_NAMES 0ac3a275c Merge pull request bareos#857 from t-mat/fix/ignore-missing-manpages bea442324 Merge pull request bareos#856 from t-mat/fix/xxh3-64bits-doxygen-documents 5e95c08a6 Merge pull request bareos#855 from t-mat/fix/xxh64-doxygen-comments 9391c17af Merge pull request bareos#853 from t-mat/feature/cli-ignore-missing 4a473192c Update xxhsum.1 c45304fb6 fix style b6103a46d add --binary to --help message e88af4632 update xxhsum.1 bfe162cae fix: add --ignore-missing to xxhsum.1.md 17dfca65f fix: add --ignore-missing to --help message c4d049b1a Add doxygen comments to XXH3_128bits_ family 58d6f48df Add doxygen comments to XXH3_64bits_ family 946d46d93 Add missing doxygen style comments to XXH64 family e592478ee add: cli: --ignore-missing 258351bd9 update CHANGELOG for v0.8.2 release c234b940f Merge pull request bareos#825 from easyaspi314/wasm128 4f092f2c6 Document NODE_JS, remove RUN_ENV hack, use proper -sNODERAWFS flag 3f255faf8 Merge pull request bareos#852 from t-mat/feature/cli-option-binary a37d21296 Merge pull request bareos#851 from t-mat/fix/doxygen-warnings-2023-0705-2 d7dce1893 feature: CLI: --binary 20bf712b9 fix: Remove ref for XXH_X86DISPATCH 6aad58a16 add: Document for XXH_IMPLEMENTATION 28f40f38e add: Document for XXH_STATIC_LINKING_ONLY f7a6acafc add: document for XXH3_*State() e2cf439b7 fix: add special #ifndef block for XXH_DOXYGEN b3214626c Add doxygen output files to .gitignore 914458d40 fixed doxygen marker 0578efda1 fixed doxygen reference 17d4aca62 Merge pull request bareos#849 from Cyan4973/sve_display 1b8956d8e fixed minor warnings 5bf31c238 added Werror to compilation tests 2d62c3e39 fix SVE tests in CI 0da2381a8 Detect and display SVE when active 0d0e823b3 updated CHANGELOG for v0.8.2 1d4ad8a3f Merge pull request bareos#848 from t-mat/fix/remove-remaining-0.8.1s ff0fa82a2 Revamp version number in Doxyfile 2c74110ed Remove tipi.build section dfd761726 update version number to v0.8.2 4c9e996ba Merge pull request bareos#847 from Cyan4973/specxxh3followup d66a9cb6f minor follow-ups for XXH3 specification (bareos#750) 0656ed753 Merge pull request bareos#750 from adrien1018/dev 811212c08 Merge pull request bareos#846 from Cyan4973/riscv 1a9e4b9f1 combine scalar-only tests 74fdef18b added RISC-V emulation to CI 10fed7eec Merge pull request bareos#845 from Cyan4973/pkgcmaketest e0f1c0214 added a cmake pkgconfig generation test 17bbdee42 Merge pull request bareos#723 from ilya-fedin/fix-cmake-prefix 5b45185d0 fix minor typo in comment 34fdc936b Merge pull request bareos#838 from t-mat/feature/issue-836 b3c34c8b3 Merge pull request bareos#840 from Cyan4973/avx_warning 7c7a82109 Merge pull request bareos#841 from Cyan4973/notipi 848f03449 removed .tipi directory bb52930b3 removed tipi test from CI suite because it's unstable 368267311 reworded the AVX error message when compiling xxh_x86dispatch.c 4823f56e1 Fix for compiler warnings e24f1115d Add CI test for # comment lines 0691980f7 Add test for # comment lines 2f405e46b feature: support # comment lines in --check files f11745eb2 Merge pull request bareos#837 from Cyan4973/dependabot/github_actions/actions/checkout-3.5.3 63d953a41 Bump actions/checkout from 3.5.2 to 3.5.3 616ca4495 minor comment update 5562a1417 Merge pull request bareos#833 from gabibguti/dev 295ee07d9 Ref actions by commit SHA in ci.yml f4bef929a Merge pull request bareos#828 from gabibguti/dev 772eb38ba Create SECURITY.md 554e98d5e Merge pull request bareos#823 from t-mat/dedicated-sanity-test-program 082a9a8d9 Document WASM SIMD128, rename an unclear macro. fd63843cd Proper documentation of the xsecret asm guard, finish comment 5a9427c27 Fix xxh_x86dispatch.c again ab50132c4 Compiler guard XXH32 on WASM128 c9a747017 [WASM] Support SIMD128 via XXH_NEON (from EMSDK's SIMDe polyfill) 125f89fb5 Add node.js wasm/asm.js tests for Github CI 207e2abcc Add some nodejs workarounds so make check works a60bd0598 Merge pull request bareos#809 from easyaspi314/aarch64-hacks c9df1e26d Merge pull request bareos#820 from Cyan4973/test816 6ff46e748 Merge pull request bareos#822 from Cyan4973/bench10 1b3dde660 Fix test name 7190dbe7a Temporarily comment out 'AARCH64, gcc-8' for incompatibility. b618de4be Fix: Invalid matrix name and AARCH64 9d34bcc73 Fix: matrix name checking logic for older versions of QEMU platforms 25dfa1aab Add Makefile entry and gitignore for sanity_test 9c377f5a2 Create sanity_test.c 464645e76 Create sanity_test_vectors.h 94ddfec14 Add sanity test vector generator 62d8bd1f2 Merge pull request bareos#819 from t-mat/gh-gcc-12 bea35c64f benchmark : adjust initial speed target to 10 MB/s 449372ca8 Merge pull request bareos#804 from easyaspi314/gcc12-Og adc4fc83f Merge pull request bareos#803 from devnexen/clang__assume 7dd426a54 added one test length for xxh sanity checks 74c416c5f Merge pull request bareos#807 from Cyan4973/gh_read 5b2032f18 Merge pull request bareos#818 from easyaspi314/fix-816 a568bee94 Merge pull request bareos#814 from t-mat/dev 5be457ea9 Merge branch 'Cyan4973:dev' into dev 09b6fc7aa Merge branch 'dev' into gh-gcc-12 3dd5a3a1c Add: GH-Actions - add gcc-12 65094db72 Fix off-by-one in XXH3_consumeStripes() (Fixes bareos#816) ca917432f Merge pull request bareos#817 from t-mat/remove-ubuntu-18.04 eaea3003f fix: GH-Actions - removed ubuntu-18.04 a09fd870c Fix: gcc -Og false positive warnings ad6394682 [NEON/VSX] Fix GCC strict aliasing issues e6732e9b8 Remove volatile from asm guards, return Clang guards 62aa2f072 changed default permissions to content:read e701df390 Various AArch64 speed hacks edb63d3e2 added read-all permission status to Github Actions Workflow ace22bddc Change whether to inline XXH3_hashLong_withSecret to a config option 2b328a109 Merge pull request bareos#805 from easyaspi314/xxh3_update_rewrite 86c3c058d Document XXH3_consumeStripes() 268fde417 Force inline withSecret when inlining only (and not on GCC 12) 44bb94ed6 Rewrite XXH3_update a2f7a0fef Fix GCC 12 -Og 4ff3a1bc3 XXH_ASSUME macro using `__builtin_assume` if supported (clang only for now). 3f5c75cc7 Merge pull request bareos#792 from goldsteinn/dev dba3a29db Merge pull request bareos#790 from hzhuang1/cmake_01 e169bed6d Merge pull request bareos#797 from dwsteele/spelling adbfd2ae7 Fix spelling. 35031d3f5 Fix `XXH_UNREACHABLE` feature test for C++23 and remove for C23 bareos#791 c17148377 cmake: support dispatch mode 6dba9abfa Merge pull request bareos#788 from goldsteinn/dev 1dc3a5c76 Merge pull request bareos#785 from hzhuang1/barrier_01 e0fd0602c Merge pull request bareos#776 from ffontaine/dev 22a9afe5c Merge pull request bareos#787 from easyaspi314/neon_refactor 2ddf958fd Define XXH_RESTRICT for some C++ compilers (gcc/clang/msvc/icc) 02303104d [NEON] Simplify, only compiler guard on Clang 2f54d1b23 [NEON] Update XXH3_NEON_LANES comment 0e73b84c9 [NEON] Refactor NEON code d7197ddea Merge pull request bareos#786 from goldsteinn/dev f4e2de694 Annotate xxh_x86dispatch with XXH_NOESCAPE fe98d2b0d Merge pull request bareos#782 from goldsteinn/dev 755445db8 Small improvements to 129to240 hash ranges 2765879dc Add __attribute__((noescape)) on pointers in public API d8c2dfe0e s390x: add memory barrier to avoid fault issue 4ebd833a2 Merge pull request bareos#778 from DimitriPapadopoulos/http 65515bb46 Merge pull request bareos#777 from DimitriPapadopoulos/codespell bdd92de7b http:// → https:// 842a149a0 Fix typo found by codespell b7c91f761 Makefile: add install_libxxhash.includes target 7f9cec78b Merge pull request bareos#773 from goldsteinn/dev b8c3176e1 dispatch: Use __attribute__((constructor)) on XXH_setDispatch 86e1f8e8a Merge pull request bareos#754 from goldsteinn/dev dced34e6e Fix '-Wsign-conversion' warning in XXH3_initCustomSecret_avx512 081c1b6e9 Merge pull request bareos#765 from Cyan4973/ci-macos12 3d010884f added macos-12 test to GH CI 30d6a3ee7 Merge pull request bareos#756 from hzhuang1/sve_02 cfbf0b720 customize full accumulating loop for ARM64 SVE 91788f167 switch to full accmulating loop 3078dc603 Merge pull request bareos#760 from tipi-deps/dev e445e5bc0 🔧 fixing Cyan4973/xxHash#759 8e94343a3 Merge pull request bareos#758 from hzhuang1/tipi_01 63356da42 CI: fix missing space d0abdaa43 Merge pull request bareos#746 from hzhuang1/cppcheck_01 dbacfec7c Merge pull request bareos#752 from hzhuang1/sve_01 7221be4f6 Speedup size hash for 17to128 by using independent accumulators. dd19080e4 CI: support ARM64 SVE c6205ae71 xxhash: add ARM SVE intrinsic implementation 267ba9485 Merge pull request bareos#742 from DimitriPapadopoulos/actions 38f1de269 Automatically update GitHub Actions in the future 2e69edec6 Update GitHub Actions b2929c469 Replace 2x vpxor with vpternlogd in avx512 scramble 1456dc5cb Avoid signed truncation in hash 17to128 and 129to240 f534e5bf0 Use `vpsrlq` instead of `vpshufd` in avx2/avx512 accumulate. 0e1d320d5 Fix errors in specification 9759aa188 Fix a typo 664c4b3d1 Add spec for medium inputs 1e02e9ae9 Add spec for small inputs 930b33de6 Add description for XXH3 for large inputs 2de0fd6d9 Merge pull request bareos#749 from hzhuang1/fix_tipi 058a4650d ci: fix tipi build error on github CI workflow dde858b9a fix issues reported by cppcheck 43ea6fdf8 Merge pull request bareos#739 from DimitriPapadopoulos/codespell 82b600a84 Fix typos found by codespell c420b5971 Merge pull request bareos#734 from dougallj/neon-opt 521e6d3bf Merge pull request bareos#718 from Cyan4973/icc_fallthrough 1309c270c Merge branch 'dev' of github.com:Cyan4973/xxHash into dev 66248f4b7 fix typo 780c3047c Merge pull request bareos#736 from t-mat/gh-actions-remove-macos-10.15 b56b0e7a7 Remove macOS-10.15 from ci.yml c5475408f Fix double prefix when building with cmake b35df4ab3 update README introduction for improved clarity 620facc54 optimize XXH3_accumulate_512_neon c4359b17d Merge pull request bareos#730 from t-mat/fix-issue-724 1dc8eb94a Merge pull request bareos#729 from t-mat/fix-makefile-glob 7a9ff0171 Add test-xxh-nnn-sums to test-all 06061c985 Add tests 02dc2abfe Introduce new enum AlgoBitmask to fix bareos#724. 051276a4b Fix: brace expansion f7ab84730 Merge pull request bareos#726 from goldsteinn/dev acfcfa97e Remove stream loads and slightly improve avx512 seed generation 6a1bda63d Merge pull request bareos#719 from another-ghasem/feature/CPackAndInstallRole 693242129 Merge branch 'Cyan4973:dev' into feature/CPackAndInstallRole b966a6f65 Merge pull request bareos#721 from Cyan4973/moreCmake2812tests cf73b4386 more cmake v2.8.12 tests ba964077f Added CPack. 7e9ada3bc blind fix for fallthrough on icc 6078dd6a8 added XXH_RESTRICT to XXH3_hashLong_64b_withSeed() f852875e1 Merge pull request bareos#711 from Cyan4973/fix682 bfd20aea9 Merge branch 'cmake_version_test' into fix682 05045561e added a CI test against minimum cmake version 4692d7537 avoid add_compile_definitions for cmake < v3.12 35ff826d5 Merge pull request bareos#710 from Cyan4973/test_escape d278c2e1d test filename-escape cc8f0d0ce Merge pull request bareos#708 from MaxiBoether/dev 93dcc6f9d Use inline ASM on IBM XL 4866da2ab Use vec_ intrinsics on IBM XL Compiler bcc4c6a0a minor man page nits 9244d6e1a Merge pull request bareos#696 from Begasus/haiku b51ffce60 Merge pull request bareos#698 from t-mat/fix-issue-695 f1f2ff913 Add test script and Makefile entry for filename escape bd4ded94e Introduce md5sum style filename escape convention 8b8618535 Build fix for Haiku aa7ac8bd1 minor build doc modification 4c223a567 Merge pull request bareos#688 from tipi-deps/dev 2ae055b84 Merge pull request bareos#690 from t-mat/fix-issue-689 0c0ea6031 Add missing apt-get update a0f750fbc Removed windows-2016 from ci.yml 7b3bb4470 Fixed up tipi CI build to do less extensive tests 81972bf47 Added tipi.build support and instructions to xxHash (incl. ci build) d8aff149b Merge pull request bareos#676 from mterron/patch-1 ab6699a9e Remove duplicated definition of XXH3_128bits b1a61dff6 Merge pull request bareos#667 from easyaspi314/sizeopt 83b2235b4 Merge pull request bareos#672 from easyaspi314/vsx_hotfix 4690bbe09 Minor typo fix ec4030d5f Properly fix altivec namespace collisions fdf28f681 [sizeopt] Reroll midrange on size opt, disable prefetch d878e1d16 Merge pull request bareos#670 from Cyan4973/fix664 6189ecd3d do no longer depend on `<assert.h>` for XXH_STATIC_ASSERT 6f9709793 Introduce XXH_SIZE_OPT and XXH_NO_STREAM 0e163593f Merge pull request bareos#662 from easyaspi314/c_attr db9c199e9 Merge pull request bareos#665 from ffontaine/dev 0e7418bce Makefile: add dedicated install targets 464054714 Fix XXH_HAS_C_ATTRIBUTE check c0d7495b2 Merge pull request bareos#661 from easyaspi314/doxygen_xxh3 2d11523a8 Add CONSTF/MALLOCF/PUREF to Doxyfile 82819102d We do a little documentation. f3eaf95f2 Merge pull request bareos#659 from Cyan4973/pure_f 08aff8bfd added __attribute__((pure)) d0f5e13d4 Merge pull request bareos#658 from Cyan4973/malloc_f 1792d8831 added __attribute__((malloc)) 30720342f Merge pull request bareos#657 from Cyan4973/const_f 74eafa97c added __attribute__((const)) 1f74f88d5 Merge pull request bareos#656 from Cyan4973/nostdlib d857cca62 improved nostdlib test 7b1fc6252 Merge pull request bareos#654 from Cyan4973/nostdlib 8e5afc71b fixed minor warnings 6d78332de new build macro XXH_NO_STDLIB a17161efb Merge pull request bareos#653 from Cyan4973/noxxh3 3fa73000e Merge pull request bareos#651 from easyaspi314/arm_go_brr 12a8d1a9c removed XXH3 declarations when XXH_NO_XXH3 is defined f035303b8 updated copyright years c0dd448b5 [ARM] Unaligned access fixes 699112254 Merge branch 'dev' of https://github.com/Cyan4973/xxHash into arm_go_brr 1a71d0aa6 Merge pull request bareos#650 from Hello71/attribute-aligned 1007890f2 Merge branch 'dev' of https://github.com/Cyan4973/xxHash into arm_go_brr fd7deb843 Use __attribute__((aligned)) instead of packed abf8f0388 [ARM/AARCH64] Fix GCC 3a1b27bd9 Merge pull request bareos#649 from Cyan4973/cmake_install 636f966ec fix cmake --install d11fd1ea8 Merge pull request bareos#648 from Cyan4973/install_man 836f4e735 fix man page installation 1607d988d Merge pull request bareos#644 from Cyan4973/fix629 daaa3ca5c Merge pull request bareos#642 from easyaspi314/arm_doc 4bfcbaa38 fix minor static analyzer warning 80f94bf1c Merge pull request bareos#643 from Cyan4973/m68k 018977589 added m68k emulation tests to GA c4716aed7 Merge pull request bareos#639 from Cyan4973/fix627 0caf2e857 Merge pull request bareos#638 from Cyan4973/fix625 43a67a781 Document XXH3_NEON_LANES, move scalarRound down. 9be82b207 Merge pull request bareos#640 from t-mat/gha/qemu-gcc-versions cc7c3406b Add QEMU/gcc matrix to ci.yml 49b2d4788 fix bareos#627 b3137c462 Merge pull request bareos#623 from easyaspi314/clang_cl_neon 4f38270b6 Merge pull request bareos#632 from easyaspi314/hybrid_neon b8ad12a60 fix bareos#625 ac5c5cb9d Merge pull request bareos#637 from t-mat/gha/clang-cl 56ac11efc Merge pull request bareos#631 from ellert/rhel7-ppc64le b7b891a40 Add clang-cl for MSVC 2019 4b5076f01 Merge pull request bareos#635 from t-mat/gha/macos-matrix 1e9aa7e73 Merge pull request bareos#634 from t-mat/gha/windows-2022 0e7c929df Add macOS matrix to ci.yml 3537ba25c Add windows-2022 to ci.yml 81adf2fae Merge pull request bareos#633 from t-mat/release-ci-badge b62417462 Merge pull request bareos#628 from dosbox-staging/kc/dev-0.8.1-pvs-fixes-1 0d23f76c1 Add GitHub Actions badge for release branch df8f69941 [NEON] Split XXH3 into 6 NEON lanes and 2 scalar lanes on aarch64 15ce80f9f Fix compilation on RHEL 7 ppc64le (gcc 4.8) b1fb0be5e Fix a typo in the assert comparing number of stripes 2e7af136e Fix CLI detection for Windows ARM and ARM64EC 85769a802 Fix some feature detection for arm/windows git-subtree-dir: third-party/xxHash git-subtree-split: bbb27a5efb85b92a0486cf361a8635715a53f6ba

arogge requested a review from pstorz June 17, 2021 15:47

arogge added 2 commits June 21, 2021 11:41

tests: run connection tests on non-ephemeral ports

74cb891

previusly these were run on high port numbers what might lead to conflicts.

systemtests: set service baseport to 30001

6c78338

Previusly, 42001 was used which could potentially lead to conflicts, as Linux uses everything above 32768 as an ephemeral port.

arogge force-pushed the dev/arogge/master/improve-testing branch from 6d2ca9a to 6c78338 Compare June 21, 2021 09:41

pstorz approved these changes Jun 21, 2021

View reviewed changes

arogge merged commit de30974 into master Jun 21, 2021

arogge deleted the dev/arogge/master/improve-testing branch June 21, 2021 09:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't use ephemeral ports for test servers #856

Don't use ephemeral ports for test servers #856

arogge commented Jun 17, 2021

Don't use ephemeral ports for test servers #856

Don't use ephemeral ports for test servers #856

Conversation

arogge commented Jun 17, 2021

Please check

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General

Source code quality