ipv6 and ipv4 default usage

[alaaeddineelamri]

Description

When no address or port directive is specified, Bareos listens by default only on IPV4. This pull request tries to make sure Bareos listens on both IPv4 and IPv6 by default. Also when the user only specifies a port, Bareos now listens on that port with both IPV4 and IPV6

Please check

• Short description and the purpose of this PR is present above this paragraph
• Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

• Git Workflow
• Automatic Sourcecode Formatting
• Check your commit messages

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General

• PR name is meaningful
• Purpose of the PR is understood
• Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
• Commit descriptions are understandable and well formatted

Source code quality

• Source code changes are understandable
• Variable and function names are meaningful
• Code comments are correct (logically and spelling)
• Required documentation changes are present and part of the PR
• bareos-check-sources --since-merge does not report any problems
• git status should not report modifications in the source tree after building and testing

Tests

• Decision taken that a system- or unittest is required (if not, then remove this paragraph)
• The decision towards a systemtest is reasonable compared to a unittest
• Testname matches exactly what is being tested
• Output of the test leads quickly to the origin of the fault

[arogge]

I see progress, but I also think it is still some way to go.
It looks like passing family=0 to AddAddress() should already do the trick, but it doesn't.
The change you did to the configuration parser code seems to target the wrong directive (i.e. Dir Port instead of Dir Address).

I'm really unhappy with the overall state of the address setup code. It feels way too complicated and it seems to be more or less impossible to improve at this point.

[arogge]

I haven't reviewed this file yet.

[pstorz]

Found some trailing spaces in the configuration files

[bruno-at-bareos]

Bonus Points :-)

• Make true also for SD Addresses, FD Addresses
• keep a way to make Bareos listening on only one protocol (for example ipv6 only)
• ensure communication are respecting normal behaviour, mean connect first ipv6, failback to ipv4.

For example during 16,17,18 this configuration allow Dir to only listen on ipv6

  DIRAddresses  = { 
     ipv6 = { addr = :: ; port = 9101 } 
 #    ipv4 = { addr = 0.0.0.0; port = 9101 } 
  }

telnet 127.0.0.1 9100 didn't allow connection with 20 this make the director to listen again to both stack.

[arogge]

I tried a few things with the configuration, and realized that if you set Dir Address to a valid IPv6 listen address (i.e. Dir Address = :: or Dir Address = ::1), the Director will listen on IPv4 0.0.0.0 but not on IPv6.
Any idea what is going on in that case?

[arogge]

Suggested change

- when setting an IPv6 address using the [DIR|SD|FD] Addresses directive, now bareos only listens on IPv6 only instead of both IPv4 and IPv6 on dual-stack. If you were using the [DIR|SD|FD] Addresses directive to create a dual-stack socket that would listen on both IPv6 AND IPv4, it won't work that way anymore. You should now also explicitely specify the IPv4 address in the directive [PR #882]

- when setting an IPv6 address using the [DIR|SD|FD] Addresses directive, now bareos only listens on IPv6 only instead of both IPv4 and IPv6 on dual-stack. If you were using the [DIR|SD|FD] Addresses directive to create a dual-stack socket that would listen on both IPv6 AND IPv4, it won't work that way anymore. You should now also explicitely specify the IPv4 address in the directive or remove the directive as listening on IPv6 and IPv4 is now the default. [PR #882]

[bruno-at-bareos]

I hope we are clear, with good sample of configuration in documentation ... I mean we have Dir Address and Dir Addresses

Only ipv6

DIR Address = ::
DIRPort = 9101

could be also declared as

  DIRAddresses  = {
    ipv6 = { addr = :: ; port = 9101 }
  }

compared to ipv6 + ipv4 (dual socket)

  DIRAddresses  = {
    ipv6 = { addr = :: ; port = 9101 }
    ipv4 = { addr = 0.0.0.0; port = 9101 }
  }

new default ?

[arogge]

the last one is the new default, and the first one didn't work previously (we just fixed it a few minutes ago).
You can also do Dir Address = 0.0.0.0 to get IPv4 only. I hope it is quite obvious the way it is implemented right now.

[pstorz]

Please fix typo

[arogge]

It is probably a good idea to improve the documentation on Dir Address, FD Address and SD Address to explain the new default and how to get IPv4/IPv6 only.