Fix for #48 #49
Merged
Fix for #48 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While I don't think reloading the image every single request is a good idea (I think it should be read on load so it's cached and won't crash if the image file doesn't exist or is deleted while the code is running), this does fix this issue and is the quickest possible fix. _Warning:_ I only tested this patch locally on my 3.7 install when upgrading a project to 1.13, and am making this PR with the GH online editor.
|
Sorry for the long delay, and thanks for the fix. I'll look into caching the favicon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I don't think reloading the image every single request is a good idea (I think it should be read on load so it's cached and won't crash if the image file doesn't exist or is deleted while the code is running), this does fix this issue and is the quickest possible fix.
Warning: I only tested this patch locally on my 3.7 install when upgrading a project to 1.13, and am making this PR with the GH online editor.