Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creds provider #16

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Creds provider #16

wants to merge 24 commits into from

Conversation

barshaul
Copy link
Owner

@barshaul barshaul commented Aug 9, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2022

Codecov Report

Merging #16 (4c82551) into master (2cea637) will decrease coverage by 0.08%.
The diff coverage is 96.53%.

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   92.20%   92.11%   -0.09%     
==========================================
  Files         111      113       +2     
  Lines       28751    29063     +312     
==========================================
+ Hits        26509    26771     +262     
- Misses       2242     2292      +50     
Impacted Files Coverage Δ
redis/cluster.py 89.85% <ø> (ø)
redis/commands/bf/__init__.py 96.73% <ø> (-3.27%) ⬇️
redis/commands/search/querystring.py 0.00% <0.00%> (ø)
setup.py 0.00% <ø> (ø)
tests/test_asyncio/test_lock.py 100.00% <ø> (ø)
redis/commands/core.py 82.06% <71.42%> (-0.05%) ⬇️
redis/asyncio/connection.py 86.61% <80.72%> (+0.50%) ⬆️
redis/connection.py 86.42% <88.00%> (-0.49%) ⬇️
redis/asyncio/lock.py 99.13% <88.88%> (+0.04%) ⬆️
redis/asyncio/cluster.py 90.77% <91.66%> (+0.48%) ⬆️
... and 44 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants