Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transcript ID cross-check #65

Closed
1 task
fruce-ki opened this issue Feb 13, 2019 · 1 comment
Closed
1 task

transcript ID cross-check #65

fruce-ki opened this issue Feb 13, 2019 · 1 comment
Assignees
Labels
bug RATs not behaving the way it is intended to.
Milestone

Comments

@fruce-ki
Copy link
Collaborator

fruce-ki commented Feb 13, 2019

See #64 , regarding the IDs in the provided look-up table not corresponding to the provided data.

fish4rodents() seems to try to shoe-horn input data onto the annotation, even when the IDs don't match. It inserts the IDs of the annotation as NA rows and keeps all the rows of the data not matching the IDs as well. As a result, the ID check at the beginning of calling DTU fails to detect the discrepancy and does not abort with an error as it should.

  • fix it
@fruce-ki fruce-ki added the bug RATs not behaving the way it is intended to. label Feb 13, 2019
@fruce-ki fruce-ki added this to the 0.7.0 milestone Feb 13, 2019
@fruce-ki fruce-ki self-assigned this Feb 13, 2019
@fruce-ki fruce-ki added the in progress Issue is actively being addressed label Jul 12, 2019
fruce-ki added a commit that referenced this issue Jul 18, 2019
I couldn't remember what scenarios the old data represented. So I remade them from scratch, trying to be less cryptic.
@fruce-ki
Copy link
Collaborator Author

fruce-ki commented Jul 18, 2019

Rather than changing fish4rodents() to add tests, I created a stronger cross-check that is called after munging the data into shape and order. This covers all the possible input sources.

The check explicitly compares the provided or computed counts table of each condition against the provided annotation, and requires that all target_ids of the count data are present in the annotation and vice versa. If there is even one unmatched ID, execution will abort. If reckless is enabled, a warning will still be shown.

@fruce-ki fruce-ki removed the in progress Issue is actively being addressed label Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug RATs not behaving the way it is intended to.
Projects
None yet
Development

No branches or pull requests

1 participant