Skip to content

Conversation

amiecorso
Copy link
Contributor

@amiecorso amiecorso commented Jul 18, 2025

What changed? Why?
This PR adds a note about Solidity's builtin transfer function and how this can't be used to send ETH to Base Accounts (or likely most smart contract wallets).

Original context came from this slack thread, and the failure to be able to withdraw ETH from the WETH smart contract due to its use of this function.

Notes to reviewers

How has it been tested?
Local review of the hosted docs
Screenshot 2025-07-18 at 10 25 03 AM

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jul 18, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-heimdall
Copy link
Collaborator

Review Error for youssefea @ 2025-07-18 17:27:23 UTC
User cannot review their own commit

@youssefea youssefea merged commit 4739165 into master Jul 18, 2025
5 of 6 checks passed
@youssefea youssefea deleted the amie/add-transfer-to-unsupported-calls-base-account branch July 18, 2025 17:27
@hellblade1488 hellblade1488 mentioned this pull request Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants