Skip to content

Fix: Use Counter for upstream_messages #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 28, 2025
Merged

Fix: Use Counter for upstream_messages #102

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f1c969
Update metrics.rs
DoTheBestToGetTheBest Sep 26, 2025
facb482
Update metrics.rs
DoTheBestToGetTheBest Sep 26, 2025
e283c62
Update metrics.rs
DoTheBestToGetTheBest Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion crates/flashblocks-rpc/src/metrics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,18 @@
use metrics::{Counter, Gauge, Histogram};
use metrics_derive::Metrics;
/// Metrics for the `reth_flashblocks` component.
/// Conventions:
/// - Durations are recorded in seconds (histograms).
/// - Counters are monotonic event counts.
/// - Gauges reflect the current value/state.
#[derive(Metrics, Clone)]
#[metrics(scope = "reth_flashblocks")]
pub struct Metrics {
#[metric(describe = "Count of times upstream receiver was closed/errored")]
pub upstream_errors: Counter,

#[metric(describe = "Count of messages received from the upstream source")]
pub upstream_messages: Gauge,
pub upstream_messages: Counter,

#[metric(describe = "Time taken to process a message")]
pub block_processing_duration: Histogram,
Expand Down