Skip to content

feat: implement Web3ApiExt to override web3_clientVersion #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: implement Web3ApiExt to override web3_clientVersion #123

wants to merge 1 commit into from

Conversation

haardikk21
Copy link
Contributor

Closes #122

@danyalprout
Copy link
Collaborator

I haven't tested this out (so maybe wrong), but I wonder if we should configure this via these env vars.

This looks like it'll also cause it to be exposed elsewhere, e.g. metrics (setup).

@haardikk21
Copy link
Contributor Author

I haven't tested this out (so maybe wrong), but I wonder if we should configure this via these env vars.

This looks like it'll also cause it to be exposed elsewhere, e.g. metrics (setup).

These are compile time env vars (env! Macro) not runtime so i dont think those will work. Can test tmr

danyalprout
danyalprout approved these changes Oct 8, 2025
View reviewed changes
Copy link
Collaborator

@danyalprout danyalprout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to figure out how to override the version tag on metrics, as that's what our internal dashboards use

@github-project-automation github-project-automation bot moved this to In Review in Project Tracking Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyalprout danyalprout danyalprout approved these changes

@cody-wang-cb cody-wang-cb Awaiting requested review from cody-wang-cb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Override web3_clientVersion
2 participants
@haardikk21 @danyalprout