Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped dotenv to 3.1 #901

Closed
wants to merge 2 commits into from
Closed

Conversation

igor-alexandrov
Copy link
Contributor

Closing #899.

@djmb
Copy link
Collaborator

djmb commented Aug 26, 2024

@igor-alexandrov - dotenv 3.0.0 has breaking changes - see https://github.com/bkeepers/dotenv/releases/tag/v3.0.0.

This one might hit people especially - "\n is no longer expanded into a newline in quoted strings. Use multi-line strings with real line breaks, or set DOTENV_LINEBREAK_MODE=legacy to preserve the old behavior".

So I think we'll save this change for Kamal 2.0.

@igor-alexandrov
Copy link
Contributor Author

@djmb maybe I am missing something, but I doubt that this change may hit people using Kamal. What examples do you have in mind?

Anyway, if you think that this change is for 2.0, I am fine with this. I already provided a workaround for the issue in #899.

@morgoth
Copy link
Contributor

morgoth commented Sep 10, 2024

@igor-alexandrov Looks like this was done in https://github.com/basecamp/kamal/pull/924/files#diff-7c2750e7045b7ddc6644f16f09b6690ad88e45b73bf747e14a1a0bf563c0f156R18

@igor-alexandrov
Copy link
Contributor Author

Closing this since it is not relevant anymore for Kamal 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants