Skip to content

clear diagnostics on close document #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 3, 2024
Merged

clear diagnostics on close document #1135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c2a06c6
fix: clear diagnostics on close document
Mar 30, 2024
8d3538b
Merge branch 'main' into clear-diagnostics-on-close
bzy-debug Apr 4, 2024
5e540ac
Merge branch 'main' into clear-diagnostics-on-close
skovhus May 3, 2024
fe73990
Bump sever to 5.3.1
skovhus May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions server/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Bash Language Server

## 5.3.1

- Clear diagnostics when closing document https://github.com/bash-lsp/bash-language-server/pull/1135

## 5.3.0

- Add support for formatting using shfmt (if installed). https://github.com/bash-lsp/bash-language-server/pull/1136
Expand Down
2 changes: 1 addition & 1 deletion server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description": "A language server for Bash",
"author": "Mads Hartmann",
"license": "MIT",
"version": "5.3.0",
"version": "5.3.1",
"main": "./out/server.js",
"typings": "./out/server.d.ts",
"bin": {
Expand Down
1 change: 1 addition & 0 deletions server/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ export default class BashServer {
})

this.documents.onDidClose((event) => {
connection.sendDiagnostics({ uri: event.document.uri, diagnostics: [] })
delete this.uriToCodeActions[event.document.uri]
})

Expand Down