Skip to content

fix: properly dispose of the client #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2025
Merged

fix: properly dispose of the client #1344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
181c478
fix: properly dispose of the client
sadan4 Oct 4, 2025
295659e
Prepare for releasing client 1.43.1
skovhus Oct 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions vscode-client/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Bash IDE

## 1.43.1
- Properly dispose client.

## 1.43.0
- Upgrade language server to 5.4.2 (treesitter upgrade).

Expand Down
2 changes: 1 addition & 1 deletion vscode-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "A language server for Bash",
"author": "Mads Hartmann",
"license": "MIT",
"version": "1.43.0",
"version": "1.43.1",
"publisher": "mads-hartmann",
"repository": {
"type": "git",
Expand Down
9 changes: 3 additions & 6 deletions vscode-client/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
TransportKind,
} from 'vscode-languageclient/node'

let client: LanguageClient
let client: LanguageClient | undefined

export const CONFIGURATION_SECTION = 'bashIde' // matching the package.json configuration section

Expand Down Expand Up @@ -60,7 +60,7 @@ export async function activate(context: ExtensionContext) {
},
}

const client = new LanguageClient('Bash IDE', 'Bash IDE', serverOptions, clientOptions)
client = new LanguageClient('Bash IDE', 'Bash IDE', serverOptions, clientOptions)
client.registerProposedFeatures()

try {
Expand All @@ -71,8 +71,5 @@ export async function activate(context: ExtensionContext) {
}

export function deactivate(): Thenable<void> | undefined {
if (!client) {
return undefined
}
return client.stop()
return client?.stop()
}