Man pages formatting fixed

[otreblan]

This fixes neoclide/coc.nvim#911

Now man pages are correctly formatted on completionItem/resolve

[skovhus]

Thanks for fixing this! Might be nice to DRY the code up a bit:

private async onCompletionResolve(
    item: LSP.CompletionItem,
  ): Promise<LSP.CompletionItem> {
    const {
      data: { name, type },
    } = item

    const getMarkdownCompletionItem = (doc: string) => ({
      ...item,
      documentation: {
        value: doc,
        kind: 'plaintext' as const
      }
    })

    try {
      if (type === 'executable') {
        const doc = await this.executables.documentation(name)
        return getMarkdownCompletionItem(doc)
      } else if (type === 'builtin') {
        const doc = await Builtins.documentation(name)
        return getMarkdownCompletionItem(doc)
      } else {
        return item
      }
    } catch (error) {
      return item
    }
  }

[otreblan]

Man pages syntax highlighting, also more DRY.

[skovhus]

Very nice! Thanks

[akurtakov]

Man pages syntax highlighting, also more DRY.

So how is this syntax highlighting generated? I don't see anything in the commit doing so.

[otreblan]

Man pages syntax highlighting, also more DRY.

So how is this syntax highlighting generated? I don't see anything in the commit doing so.

https://github.com/mads-hartmann/bash-language-server/blob/5dd9db04cae234d8f9d3d2d18153b7a1d3c16a1b/server/src/server.ts#L139

It's a markdown code block