-
-
Notifications
You must be signed in to change notification settings - Fork 93
Allow empty string as flag argument #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
creating user files in src | ||
skipped src/initialize.sh (exists) | ||
skipped src/test_command.sh (exists) | ||
created ./cli | ||
run ./cli --help to test your bash script | ||
+ ./cli test '' | ||
# this file is located in 'src/test_command.sh' | ||
# code for 'cli test' goes here | ||
# you can edit it freely and regenerate (it will not be overwritten) | ||
args: | ||
- ${args[arg]} = | ||
+ ./cli test --flag '' | ||
# this file is located in 'src/test_command.sh' | ||
# code for 'cli test' goes here | ||
# you can edit it freely and regenerate (it will not be overwritten) | ||
args: | ||
- ${args[--flag]} = |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
cli |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
name: cli | ||
help: Sample application | ||
version: 0.1.0 | ||
|
||
commands: | ||
- name: test | ||
help: Run test | ||
flags: | ||
- long: --flag | ||
arg: value | ||
args: | ||
- name: arg | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
# Code here runs inside the initialize() function | ||
# Use it for anything that you need to run before any other function, like | ||
# setting environment vairables: | ||
# CONFIG_FILE=settings.ini | ||
# | ||
# Feel free to empty (but not delete) this file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
echo "# this file is located in 'src/test_command.sh'" | ||
echo "# code for 'cli test' goes here" | ||
echo "# you can edit it freely and regenerate (it will not be overwritten)" | ||
inspect_args |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
#!/usr/bin/env bash | ||
|
||
# This fixture tests Bash 4+-only syntax | ||
# It is executed as part of the Runfile examples test | ||
|
||
bundle exec bashly generate | ||
|
||
set -x | ||
|
||
./cli test '' | ||
./cli test --flag '' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we add another arg, so that we have one optional and one required? As I have learned in #130, there are two places these args are handled.