Skip to content

Conversation

DannyBen
Copy link
Member

@DannyBen DannyBen commented Jan 3, 2023

The static analysis workflow was reporting success when it in fact, did nothing.
This is due to the fact that:

  1. The example executables were not generated in this job, since the executables are gitignored and should be generated.
  2. The shellcheck/shfmt testers were skipping examples with missing executables.

The fix:

  1. Add a task to generate examples.
  2. Make sure the shellcheck/shfmt tasks fail if there are more than X skips.

@DannyBen DannyBen merged commit 963d66b into master Jan 3, 2023
@DannyBen DannyBen deleted the fix/static-ci branch January 3, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant