Fix arg.allowed and flag.allowed to allow setting without required or default
#372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DannyBen
changed the title
arg.allowed and flag.allowed to allow setting without required or default
DannyBen
commented
Apr 7, 2023
There was a problem hiding this comment.
This change modifies the whitelist filter to only validate the contents of the variable if it is not empty.
In case the flag/arg are set to require: true, we will never reach this code since it will be blocked earlier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #368
This is a revert of #370 plus a fix to allow the whitelist to be optional and without a default value.