Skip to content

Allow using bashly-settings.yml instead of settings.yml #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2023

Conversation

DannyBen
Copy link
Member

@DannyBen DannyBen commented Apr 18, 2023

Closes #381


Before this PR:
Settings file location is either settings.yml or whatever is defined in BASHLY_SETTINGS_PATH environment variable.

After this PR:
Settings file location is either bashly-settings.yml, or settings.yml or whatever is defined in BASHLY_SETTINGS_PATH environment variable.

https://github.com/DannyBen/bashly/blob/16ba317aeca415736ee5687fae130dbfb520acc1/lib/bashly/settings.rb#L103-L111

In addition, the Settings specs were refactored a bit to ensure the specs work with a known state of the Settings eigenclass.

@DannyBen
Copy link
Member Author

@EmilySeville7cfg - this is done only to satisfy the JSON schema use case you mentioned.

Is this an acceptable compromise?

@EmilyGraceSeville7cf
Copy link
Collaborator

EmilyGraceSeville7cf commented Apr 18, 2023

Is this an acceptable compromise?

Sure, it is the best decision I see here.

@DannyBen DannyBen merged commit a533cf8 into master Apr 18, 2023
@DannyBen DannyBen deleted the add/bashly-settings-filename-support branch April 18, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decide whether to use bashly- prefix for YAML configs
2 participants