Skip to content

Fix shellcheck violations #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 14, 2024
Merged

Fix shellcheck violations #535

merged 3 commits into from
Jul 14, 2024

Conversation

DannyBen
Copy link
Member

@DannyBen DannyBen commented Jul 14, 2024 •
edited
Loading

cc #534

In this PR:

  1. Separated static analysis and test CI workflows.
  2. Updated static analysis workflow to run shellcheck and shfmt on spec/fixtures/workspaces/* in addition to running on all examples.
  3. Add run fixtures to regenerate fixture scripts.
  4. Update run shellcheck and run shfmt to also allow checking fixtures in addition to checking the examples.
  5. Update run examples, run shellcheck and the run fixtures to accept arg for filter instead of relying on ENV['EXAMPLE'].
  6. Fix all found shellcheck and shfmt violations.

@DannyBen DannyBen changed the title Fix shellcheck violations and reduce use of eval Fix shellcheck violations Jul 14, 2024
@DannyBen DannyBen merged commit 908edc6 into master Jul 14, 2024
@DannyBen DannyBen deleted the fix/shellcheck branch July 14, 2024 12:43
@DannyBen DannyBen mentioned this pull request Jul 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DannyBen