add optional key transformer to support new key formats #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -121,6 +123,10 @@ open(Dirname, Opts) -> | |||
| %% Get the number of seconds we are willing to wait for the keydir init to timeout | |||
| WaitTime = timer:seconds(get_opt(open_timeout, Opts)), | |||
|
|
|||
| %% Set the key transform for this cask | |||
| KeyTransformFun = get_opt(key_transform, Opts), | |||
| erlang:put(key_transform, KeyTransformFun), | |||
There was a problem hiding this comment.
This is also stroed in the 'state', why store it in 2 places in the process dictionary?
|
Other than the cosmetic issues mentioned, this looks and works fine +1 once concerns are addressed. |
|
Looks good. +1. |
evanmcc
added a commit
that referenced
this pull request
Sep 20, 2013
add optional key transformer to support new key formats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since key formats can change over time, we should allow the application some control of the versions that are read off of the disk. This patch is adds this capability, in order to allow a change in riak_kv that makes the keys take up less space in memory.