Skip to content

Strip path off buffer files before calling get_id_number to avoid problem if path contains a dash #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Strip path off buffer files before calling get_id_number to avoid problem if path contains a dash #10

wants to merge 3 commits into from

Conversation

kellymclaughlin
Copy link
Contributor

I ran across this problem while quickchecking riak_kv_index_backend. I set the data_root to test/merge_index-backend and it exposed the problem.

@rzezeski
Copy link
Contributor

This should also address this issue.

@rzezeski
Copy link
Contributor

It also address issue 1086.

@Vagabond
Copy link
Contributor

I've tested this and the patch does fix the issue. However, why didn't you use filename:basename or something instead of that substr. Also, a unit test would be nice (not sure how feasible it is, though).

@Vagabond
Copy link
Contributor

+1 for merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kellymclaughlin @rzezeski @Vagabond