Extract Protocol Buffers encoding/decoding from client #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Don't run tests for deps.
| @@ -1,6 +1,6 @@ | |||
| {cover_enabled, true}. | |||
| {erl_opts, [warnings_as_errors]}. | |||
| {deps, [ | |||
| {protobuffs, "0.6.*", {git, "git://github.com/basho/erlang_protobuffs", {tag, "protobuffs-0.6.0"}}} | |||
| {riak_pb, "1.2.*", {git, "git://github.com/basho/riak_pb", "master"}} | |||
There was a problem hiding this comment.
I see no reason to fix on version for master.
There was a problem hiding this comment.
You mean to use a ".*" version?
There was a problem hiding this comment.
Yea, IIRC that's what we do for everything else on master.
|
I walked through this code making sure what was removed was migrated to +1 to merge. |
added 2 commits
June 5, 2012 00:01
|
+1 to merge |
seancribbs
pushed a commit
that referenced
this pull request
Jun 5, 2012
Extract Protocol Buffers encoding/decoding from client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of a series of pull requests to refactor the PBC interface of Riak and make it more general.
Related: basho/riak_kv#321, basho/riak#138, basho/riak_pb, basho/riak_api
All encoding and decoding functions and
.protofiles were removed from the client library and moved into the newriak_pbapplication. This enables us to keep a single source-of-truth about the serialization format of protocol messages that is reused in the client and server and independent of both of them, and to remove the dependency of the server on the client library (a needless coupling).