Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump plugins and dependencies. #631

Merged
merged 2 commits into from
Jul 19, 2016

Conversation

guidomedina
Copy link

Bump plugins and dependencies, the following are the most relevant:

  • Netty to 4.0.38.Final
  • Jackson to 2.8.0
  • Slf4j to 1.7.21
  • Jinterface to 1.6.1

It all compiles and all tests ran locally passed.

@guidomedina
Copy link
Author

  • Riak Java Client version: 2.0.6
  • Java version: 1.8
  • Riak version: 2.1.4
  • Operating System / Distribution & Version: Ubuntu 14.04 Server LTS
  • Riak's error.log file, if applicable: N/A
  • What methods were being executed during the error: N/A
  • What you expected to have happen: Nothing really, I used to contribute to Riak 1.x a couple of years ago, warming up again with this easy PR which should be harmless and benefitial.
  • Sample data, if applicable: N/A

@alexmoore
Copy link
Contributor

Hey @guidomedina,
Thanks for the PR!

I'll take a look at the changes for each lib update. We've been bitten before by upgrading (#619), so I'll need to see if anything breaks - hopefully it doesn't.

Thanks,
Alex

@guidomedina
Copy link
Author

guidomedina commented Jul 13, 2016

@alexmoore have you tested the Riak Java client with Netty 4.1.x?

At the moment we use another framework that we can't upgrade because of compatibility issues between Netty 4.0.x and 4.1.x so I was wondering if Riak Java client have been tested with Netty 4.1.x

In the meantime I will test on my side and maybe -because this PR has been postponed for 2.1.x- re-push with Netty 4.1.x if it works for me.

@guidomedina
Copy link
Author

guidomedina commented Jul 13, 2016

@alexmoore I have added one more commit with Netty migration to 4.1.x including a deprecated API use fixed.

I will do some more tests here and if it works we would build an internal version with it, you can always cherry pick the first commit if the 2nd isn't aligned with Riak Java client's moving forward plan.

Edit: It seems to work fine with Netty 4.1.2.Final

@guidomedina guidomedina force-pushed the gm-bump-plugins-and-dependencies branch from ce765ac to 2d42ccb Compare July 19, 2016 11:21
@guidomedina
Copy link
Author

Updated to 4.1.3.Final and force pushed.

@alexmoore
Copy link
Contributor

+1

@alexmoore alexmoore merged commit efd1f96 into basho:develop Jul 19, 2016
@guidomedina guidomedina deleted the gm-bump-plugins-and-dependencies branch July 20, 2016 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants