-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump plugins and dependencies. #631
Bump plugins and dependencies. #631
Conversation
|
Hey @guidomedina, I'll take a look at the changes for each lib update. We've been bitten before by upgrading (#619), so I'll need to see if anything breaks - hopefully it doesn't. Thanks, |
@alexmoore have you tested the Riak Java client with Netty 4.1.x? At the moment we use another framework that we can't upgrade because of compatibility issues between Netty 4.0.x and 4.1.x so I was wondering if Riak Java client have been tested with Netty 4.1.x In the meantime I will test on my side and maybe -because this PR has been postponed for 2.1.x- re-push with Netty 4.1.x if it works for me. |
@alexmoore I have added one more commit with Netty migration to 4.1.x including a deprecated API use fixed. I will do some more tests here and if it works we would build an internal version with it, you can always cherry pick the first commit if the 2nd isn't aligned with Riak Java client's moving forward plan. Edit: It seems to work fine with Netty 4.1.2.Final |
ce765ac
to
2d42ccb
Compare
Updated to 4.1.3.Final and force pushed. |
+1 |
Bump plugins and dependencies, the following are the most relevant:
It all compiles and all tests ran locally passed.