Reduce unused channel close log message to info #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmoore
changed the title
| @@ -136,7 +136,7 @@ public void operationComplete(ChannelFuture future) throws Exception | |||
| // the next time it's pulled from the pool. | |||
| // We record the disco for the health check. | |||
| recentlyClosed.add(new ChannelWithIdleTime(future.channel())); | |||
| logger.error("inAvailable channel closed; id:{} {}:{}", | |||
| logger.warn("Available channel closed; id:{} {}:{}", | |||
There was a problem hiding this comment.
@alexmoore Not sure whether it should be a warning, since it is an ordinal situation
There was a problem hiding this comment.
It could be normal, or could signify something bigger is going on with the network / application if seen in conjunction with other errors, or many of them grouped together.
https://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/Level.html#WARN
There was a problem hiding this comment.
IMO it is either INFO or DEBUG
|
👍 LGTM |
alexmoore
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #628 (CLIENTS-895)