Spark related changes FBR and PEx #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksii-suprun
force-pushed
the
merge-dpclient-rebased
branch
2 times, most recently
from
0f2aa85
to
ed97e24
Compare
|
build it please |
…text in 2i queries
… full bucket read
…ntroduce workaround for Full Bucket Reads without providing any keys
… any coverage entry with ip '0.0.0.0'.
…lder#withReplaceCoverageContext method
…table/alternative Riak Nodes
… be run in teh scope of Timeseries tests, since PEx in KV hasn't been released yet.
oleksii-suprun
force-pushed
the
merge-dpclient-rebased
branch
from
44495c9
to
05fbe31
Compare
|
Looks pretty good, and alternate coverage tests work (yey). A few minor notes incoming... |
| return results; | ||
| } | ||
|
|
||
| // TODO: Add test for JSON values |
|
+1 with the requested docs changes and fix/remove TODOs. |
|
build it please |
|
Buildbot isn't picking up the last change, but 05fbe31 was successful, only changes since then are comment related. +1 merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR Introduces changes required for Spark Connector like a Full Bucket Read and Parallel Extract and minor fixes.
It is reincarnation of #612 and here is a task list from the original PR created after review:
withReturnBody()in SecondaryIndexQueryOperation:Builder