Ready: Add isNotFound parameter to data type responses #654
Conversation
alexmoore
changed the title
|
|
||
| private final Map<BinaryValue, List<RiakDatatype>> entries = | ||
| new HashMap<BinaryValue, List<RiakDatatype>>(); | ||
| private final Map<BinaryValue, List<RiakDatatype>> entries = new HashMap<>(); |
There was a problem hiding this comment.
I don't understand this change, why is it in with a PR that adds a NotFound field to the fetch response?
There was a problem hiding this comment.
Pretty sure this is a resharper code standards format change. He is updating files as he touches them.
There was a problem hiding this comment.
Yep, just a general safe refactoring to standardize spacing, formatting etc as I touch files. I should have moved that specific one into a separate commit but probably saw red at the mixing of tabs and spaces.
|
The code looks good. One question: there seems to be at least 2 things in this PR 1. the change as described 2. a general refactor. I think 2 PRs would have been better. |
|
I can't get the iTests to run, I just get Will wait for @alexmoore to get in rather than persist at this point |
|
👍 Tests pass, code looks good. |
|
@russelldb I'll try to at least split them into different commits in the future. I've been avoiding a "mega-refactor" PR, just because it would be terrible to review everything all at once. reformatting as I go seems to work though. |
| * @return a Long value for this RiakCounter. | ||
| */ | ||
| @Override | ||
| @Override | ||
| public Long view() |
There was a problem hiding this comment.
Why don't us change Long to long to avoid Boxing..
UPD: it turned out that this Long is dropping from RiakDatatype, therefore IMO better to change:
private long value = 0;
to use Long instead of long, and maybe even to make RiakDatatype be a Generic class
|
+1 Tests pass. Looks good. WFM |
Fixes #536 (CLIENTS-552).