Add HyperLogLog Data Type #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @Override | ||
| public RiakHll extractDatatype(RiakDatatype element) | ||
| { | ||
| return element.getAsHLL(); |
There was a problem hiding this comment.
Hll (lowercase l characters) is used elsewhere. I can't say I like the way either version looks, though 😄
There was a problem hiding this comment.
Yeah, HLL, Hll, and HyperLogLog all have their downsides, I just chose the least annoying 😄
There was a problem hiding this comment.
Well, it should probably be consistently Hll everywhere.
There was a problem hiding this comment.
Ahh h(e)ll, I'll root out those non-compliant vars.
|
👍 tests ran successfully against |
| * this class is used to encapsulate the update to be performed on a | ||
| * Riak HyperLogLog datatype. | ||
| * </p> | ||
| * @author Dave Rusek <drusek at basho dot com> |
There was a problem hiding this comment.
Shhh, we keep him in the closet.
|
Several |
| @@ -72,7 +72,7 @@ public HllUpdate add(String element) | |||
| */ | |||
| public HllUpdate addAllBinary(Collection<BinaryValue> elements) | |||
| { | |||
| if(elements == null) | |||
| if (elements == null) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds HLL data type.
Test with a devrel of this Riak branch: https://github.com/basho/riak_ee/tree/develop-2.2
Test / sample usage can be found at:
riak-java-client/src/test/java/com/basho/riak/client/api/commands/itest/ITestDatatype.java
Line 157 in 00fc012
When running maven, add the flag
-Dcom.basho.riak.hlldt=trueto enable the new tests.Docs PR forthcoming.