Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of charset lookups performed in BinaryValue under t… #688

Merged
merged 1 commit into from
Nov 16, 2016

Conversation

srgg
Copy link
Contributor

@srgg srgg commented Nov 16, 2016

Description

Getting rid of looking up UTF charset each time when
BinaryValue.createFromUtf8() and BinaryValue. toStringUtf8() is called

Motivation and Context

To speed-up corresponding operations

How Has This Been Tested?

It is expected that this change will be covered by existing tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Inapplicable

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Javadoc comments for any new public classes, interfaces, etc.
  • A basho_docs PR for new or changed features (basho/basho_docs#???)

Pull requests that are small and limited in scope are most welcome.

@alexmoore alexmoore merged commit 6d7a9d2 into develop Nov 16, 2016
@alexmoore alexmoore deleted the speedup-binaryval-utf8 branch November 16, 2016 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants