Changed `riak attach` to use a remsh #254

angrycub · 2012-12-06T20:12:23Z

This serves to insulate the running riak Erlang Virtual Machine from
accidental CTRL-C's causing it to halt. The original behavior has been
moved to riak attach-direct

This serves to insulate the running riak Erlang Virtual Machine from accidental CTRL-C's causing it to halt. The original behavior has been moved to `riak attach-direct`

evanmcc · 2012-12-06T20:17:46Z

rel/files/riak

@@ -23,6 +23,31 @@ RUNNER_LOG_DIR={{runner_log_dir}}
 # Note the trailing slash on $PIPE_DIR/
 PIPE_DIR={{pipe_dir}}
 RUNNER_USER={{runner_user}}
+PLATFORM_DATA_DIR={{platform_data_dir}}#!/bin/sh
+# -*- tab-width:4;indent-tabs-mode:nil -*-


If we want to do this stuff, it belongs at the top, not at line 27.

That stuff is already at the top, looks like a bad merge/diff to me.

I think it's copypasta.

jaredmorrow · 2012-12-06T20:20:42Z

So if you look at the resulting file, there is two of everything. Take a look at your branch and re-push to this PR.

jaredmorrow · 2012-12-06T20:21:34Z

Also, this might need to wait until after we branch 1.3 unless there is a bug associated that is a must-need.

evanmcc · 2012-12-06T20:46:50Z

That looks a lot better.

I think that it can wait till after 1.3, although it's a pretty strong nice-to-have.

jaredmorrow · 2012-12-06T20:57:29Z

So, if it is a nice-to-have, I'd be more inclined to +1 if the new functionality was something like attach-nice with attach staying the same for 1.3. Also, I'd hold off on any +1 for a test addition to the basic_command_line test in riak_test.

evanmcc · 2012-12-06T21:06:25Z

My feeling is that attach should go away, and I'm willing to wait for 1.4
if that's what it takes to get it to happen.

I'll work with charlie to get an update to riak_test.

On Thu, Dec 6, 2012 at 12:57 PM, Jared Morrow notifications@github.comwrote:

So, if it is a nice-to-have, I'd be more inclined to +1 if the new
functionality was something like attach-nice with attach staying the same
for 1.3. Also, I'd hold off on any +1 for a test addition to the
basic_command_line test in riak_test.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/254#issuecomment-11103433.

seancribbs · 2012-12-06T21:11:14Z

@evanmcc Disagree. In scenarios where disterl is unresponsive, remsh might refuse to connect but attach always has the pipes.

angrycub · 2012-12-06T21:13:57Z

I'd just not like it to be the "go to" version of how we connect. I like the idea of keeping the piped version in, just as a different name. Working on some riak-tests now to test the behavior.

evanmcc · 2012-12-06T21:18:53Z

@seancribbs this retains attach as attach-direct with all of its
functionality intact.

On Thu, Dec 6, 2012 at 1:13 PM, Charlie Voiselle
notifications@github.comwrote:

I'd just not like it to be the "go to" version of how we connect. I like
the idea of keeping the piped version in, just as a different name. Working
on some riak-tests now to test the behavior.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/254#issuecomment-11104408.

seancribbs · 2012-12-06T21:40:10Z

@evanmcc I know, I was more commenting on your suggestion to remove it entirely. Aside from the inability for Erlang to daemonize itself sensibly, having the run_erl/to_erl pair can be extremely helpful for support.

evanmcc · 2012-12-06T21:41:35Z

I totally agree, Sean. By go away, I meant as the default. Sorry if there
was any confusion.

On Thu, Dec 6, 2012 at 1:40 PM, Sean Cribbs notifications@github.comwrote:

@evanmcc https://github.com/evanmcc I know, I was more commenting on
your suggestion to remove it entirely. Aside from the inability for Erlang
to daemonize itself sensibly, having the run_erl/to_erl pair can be
extremely helpful for support.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/254#issuecomment-11106045.

seancribbs · 2012-12-06T21:47:17Z

@evanmcc 🍻

seancribbs · 2012-12-09T19:27:34Z

I might also mention that running q(). from the remsh still quits the Riak node. At least you won't hang it by hitting Ctrl-C, however.

evanmcc · 2012-12-10T17:51:17Z

Looking into what it would take to adding a restricted shell. It doesn't
seem particularly hard, more of a build problem than a coding issue.

On Sun, Dec 9, 2012 at 11:27 AM, Sean Cribbs notifications@github.comwrote:

I might also mention that running q(). from the remsh still quits the
Riak node. At least you won't hang it by hitting Ctrl-C, however.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/254#issuecomment-11174699.

doubleyou · 2013-01-08T16:57:19Z

My 5 cents: #265 (comment)

rzezeski · 2013-01-08T17:11:44Z

I vote we make attach use remsh by default, here are my reasons:

If lager console is enabled and node is busy then it can be impossible to do anything because logging msgs clobber all your input/output.
If you mess with any shared binaries or make other big structures the memory will continue to be used even after you detach.
I recently watched a customer bring down multiple nodes by using Ctrl-C, and being fairly upset about it.

doubleyou · 2013-01-08T17:14:49Z

I'll repeat myself here, but why use run_erl in the first place? Does it have any benefits except logs rotation?

seancribbs · 2013-01-08T18:58:27Z

@doubleyou See my comment above. If disterl is unresponsive (busy_dist_port, e.g.), connecting to the fifos will still work.

evanmcc · 2013-04-08T21:30:14Z

Any objections to merging this before the upcoming freeze? I note that it's still hanging out here, lacking consensus. I'd like to re-review the code, but my opinion is that it should go in.

reiddraper · 2013-04-08T21:34:19Z

If we go with this, let's also update Riak Enterprise, Riak CS, Stanchion and any other projects which have an attach feature.

jaredmorrow · 2013-04-08T21:45:17Z

@evanmcc I'd like to see a test added to https://github.com/basho/riak_test/blob/master/tests/basic_command_line.erl if new behavior and old behavior (moving run_erl to a different command) is tested and working, I'm +1. @reiddraper if it makes it in, I'll move it into node_package and add it to cs/stanchion/etc.

jaredmorrow · 2013-04-09T19:24:40Z

I'll pick this up for testing.

jaredmorrow · 2013-04-11T12:55:59Z

Wrote partial riak_test, but having trouble with some riak_test functionality. Tested a lot by hand, and added details to release notes. @angrycub if you can handle a PR to docs.basho.com to update any mention of riak attach I'll finish the riak_test. In the meantime, this can be merged.

Changed `riak attach` to use a remsh

Adds attach_direct function to correspond to `riak attach-direct` as well as change the basic_command_line test to test both `riak attach` and `riak attach-direct`. Corresponds to functionality added in basho/riak#254

joedevivo · 2013-04-15T23:49:18Z

you broke my ❤️ @angrycub, YOU BROKE MY ❤️!

Add riak-admin ensemble-status command

Add Repair Keys AAE Fold

Changed riak attach to use a remsh...

141bfa9

This serves to insulate the running riak Erlang Virtual Machine from accidental CTRL-C's causing it to halt. The original behavior has been moved to `riak attach-direct`

evanmcc reviewed Dec 6, 2012
View reviewed changes

Fixing copypasta error

267af3c

Charlie Voiselle added 4 commits December 6, 2012 15:32

Corrected regex for argument filtering

47d0e14

Rebased this change off of a master-branch rel/files/riak file

c65136b

Line ending cleanup.

00edb7d

Added attach and attach-direct to the help line.

e9cbd96

jaredmorrow mentioned this pull request Jan 8, 2013

Add daemontools support #265

Closed

ghost assigned jaredmorrow Apr 9, 2013

jaredmorrow added a commit that referenced this pull request Apr 11, 2013

Merge pull request #254 from angrycub/master

cb9e224

Changed `riak attach` to use a remsh

jaredmorrow merged commit cb9e224 into basho:master Apr 11, 2013

lgustafson mentioned this pull request Sep 27, 2014

Document support for foreground process managers #602

Open

hmmr pushed a commit that referenced this pull request Nov 8, 2016

Merge pull request #254 from basho/feature/ensemble-commands

65514ec

Add riak-admin ensemble-status command

martincox pushed a commit that referenced this pull request Jan 31, 2022

Merge pull request #254 from basho/mas-i1793-repairkeysrange

d1f7231

Add Repair Keys AAE Fold

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changed `riak attach` to use a remsh #254

Changed `riak attach` to use a remsh #254

angrycub commented Dec 6, 2012

evanmcc Dec 6, 2012

jaredmorrow Dec 6, 2012

angrycub Dec 6, 2012

jaredmorrow commented Dec 6, 2012

jaredmorrow commented Dec 6, 2012

evanmcc commented Dec 6, 2012

jaredmorrow commented Dec 6, 2012

evanmcc commented Dec 6, 2012

seancribbs commented Dec 6, 2012

angrycub commented Dec 6, 2012

evanmcc commented Dec 6, 2012

seancribbs commented Dec 6, 2012

evanmcc commented Dec 6, 2012

seancribbs commented Dec 6, 2012

seancribbs commented Dec 9, 2012

evanmcc commented Dec 10, 2012

doubleyou commented Jan 8, 2013

rzezeski commented Jan 8, 2013

doubleyou commented Jan 8, 2013

seancribbs commented Jan 8, 2013

evanmcc commented Apr 8, 2013

reiddraper commented Apr 8, 2013

jaredmorrow commented Apr 8, 2013

jaredmorrow commented Apr 9, 2013

jaredmorrow commented Apr 11, 2013

joedevivo commented Apr 15, 2013

Changed riak attach to use a remsh #254

Changed riak attach to use a remsh #254

Conversation

angrycub commented Dec 6, 2012

evanmcc Dec 6, 2012

Choose a reason for hiding this comment

jaredmorrow Dec 6, 2012

Choose a reason for hiding this comment

angrycub Dec 6, 2012

Choose a reason for hiding this comment

jaredmorrow commented Dec 6, 2012

jaredmorrow commented Dec 6, 2012

evanmcc commented Dec 6, 2012

jaredmorrow commented Dec 6, 2012

evanmcc commented Dec 6, 2012

seancribbs commented Dec 6, 2012

angrycub commented Dec 6, 2012

evanmcc commented Dec 6, 2012

seancribbs commented Dec 6, 2012

evanmcc commented Dec 6, 2012

seancribbs commented Dec 6, 2012

seancribbs commented Dec 9, 2012

evanmcc commented Dec 10, 2012

doubleyou commented Jan 8, 2013

rzezeski commented Jan 8, 2013

doubleyou commented Jan 8, 2013

seancribbs commented Jan 8, 2013

evanmcc commented Apr 8, 2013

reiddraper commented Apr 8, 2013

jaredmorrow commented Apr 8, 2013

jaredmorrow commented Apr 9, 2013

jaredmorrow commented Apr 11, 2013

joedevivo commented Apr 15, 2013

Changed `riak attach` to use a remsh #254

Changed `riak attach` to use a remsh #254