refactored riak.schema bits to other repos

[joedevivo]

The culmination of a week's worth of refactoring schemas into other repos

[jrwest]

these changes are already on develop [1] and some, like lager, seem more recent. Should this be removed before merge?

[1] https://github.com/basho/riak/blob/develop/rebar.config#L16

[jrwest]

I uncommented erlang.zdbbl = 32MB in the generated config and cuttlefish failed with:

$ dev/dev1/bin/riak console 
00:49:12.774 [info] Application lager started on node nonode@nohost
00:49:12.774 [info] Checking /home/jordan/sandbox/basho/review/jd-cuttlefish-riak/riak/dev/dev1/bin/../etc/app.config exists... false
00:49:12.774 [info] Checking /home/jordan/sandbox/basho/review/jd-cuttlefish-riak/riak/dev/dev1/bin/../etc/vm.args exists... false
00:49:12.774 [info] No app.config or vm.args detected in /home/jordan/sandbox/basho/review/jd-cuttlefish-riak/riak/dev/dev1/bin/../etc, activating cuttlefish
00:49:12.858 [info] Adding Defaults
00:49:12.863 [info] Applying Datatypes
00:49:12.864 [info] Validation
00:49:12.865 [info] Applied 1:1 Mappings
00:49:12.865 [info] Applied Translations
Error generating config with cuttlefish, there should be logs

This is a fresh checkout of Riak and jd-cuttlefish but I rebased on develop (and resolved conflicts in rebar.config in favor of develop). I tried un-commenting a few other options including erlang.swfi but this is the only one that gave me problems.

Also, I noticed if cuttlefish fails, riak start errors with riak failed to start within 15 seconds. Is this something we plan to fix? Its unclear that you need to riak console to figure out the cuttlefish error and why wait 15 seconds when we know the error immediately?

[joedevivo]

zdbbl is hitting some weird corner case in cuttlefish that I don't have time to get to the bottom of today. For now I've removed the datatype from zdbbl so it's useable. Will dig into this for the next "pre" or whatever.

[joedevivo]

The thing about 15 seconds is most likely a node_package thing. It's been that way from the start, so I don't think a blocker, but it is worth fixing. I'll get to it next week.

[jrwest]

now, when I un-comment erlang.zddbl Erlang says: Invalid dbbl limit: 33554432 along w/ a bunch of help output. Pretty sure the problem is the value is in bytes not kilobytes...

also from the output:

-zdbbl size set the distribution buffer busy limit in kilobytes
            valid range is [1-2097151]

Erlang:

Erlang R16B02 (erts-5.10.3) [source] [64-bit] [smp:8:8] [async-threads:10] [kernel-poll:false]

Update: changed value to 32768 in riak.conf and Riak now boots fine.

[jrwest]

Verified control config is generated w/ recent changes. After fixing the zdbbl default +1 to merge.

[evanmcc]

Reviewed Jordan's commit, it works as expected and the change shows up when running.

[jrwest]

Pushed a fix for zdbbl and @evanmcc double checked it. Merging (as @joedevivo requested).