-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactored riak.schema bits to other repos #413
Conversation
{cluster_info, ".*", {git, "git://github.com/basho/cluster_info", {branch, "develop"}}}, | ||
{riak_kv, ".*", {git, "git://github.com/basho/riak_kv", {branch, "develop"}}}, | ||
{riak_search, ".*", {git, "git://github.com/basho/riak_search", | ||
{node_package, ".*", {git, "git://github.com/basho/node_package.git", {branch, "develop"}}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these changes are already on develop
[1] and some, like lager, seem more recent. Should this be removed before merge?
[1] https://github.com/basho/riak/blob/develop/rebar.config#L16
I uncommented
This is a fresh checkout of Riak and Also, I noticed if cuttlefish fails, |
zdbbl is hitting some weird corner case in cuttlefish that I don't have time to get to the bottom of today. For now I've removed the datatype from zdbbl so it's useable. Will dig into this for the next "pre" or whatever. |
The thing about 15 seconds is most likely a node_package thing. It's been that way from the start, so I don't think a blocker, but it is worth fixing. I'll get to it next week. |
now, when I un-comment also from the output:
Erlang:
Update: changed value to |
Verified control config is generated w/ recent changes. After fixing the |
Reviewed Jordan's commit, it works as expected and the change shows up when running. |
Pushed a fix for |
refactored riak.schema bits to other repos
The culmination of a week's worth of refactoring schemas into other repos