Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update riak cs debug [RCS-284] #1236

Merged
merged 7 commits into from
Sep 8, 2015
Merged

Conversation

ksauzz
Copy link
Contributor

@ksauzz ksauzz commented Sep 4, 2015

This work is for merging a update of riak-debug on #1116, and includes some fixes to work with latest Riak CS.
I tested this on CentOS and Ubuntu manually.

@shino shino added this to the 2.1.0 milestone Sep 4, 2015
-e, --extracmds Gather extra command output. These commands are too intense
to run on all nodes in a cluster but appropriate for a
single node.
-v, --verbose Print verbose failure messages to stdout
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful option 🪲
The code below seems that messages are output to std_err_, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable.

@shino
Copy link
Contributor

shino commented Sep 7, 2015

Nice work! I like newly introduced option verbose 😄
Added two small comments, will 👍 after they are discussed and/or fixed.

- redirect verbose output to stderr
- avoid to concatnating syslog and kern.log to messages
@kuenishi kuenishi changed the title Update riak cs debug Update riak cs debug [RCS-284] Sep 7, 2015
borshop added a commit that referenced this pull request Sep 8, 2015
Update riak cs debug [RCS-284]

Reviewed-by: shino
@kuenishi
Copy link
Contributor

kuenishi commented Sep 8, 2015

@borshop merge

@borshop borshop merged commit 0a3cfd8 into develop Sep 8, 2015
@shino shino deleted the feature/kaz-update-riak-cs-debug branch September 8, 2015 07:26
@kuenishi
Copy link
Contributor

Summary for release notes?

@shino
Copy link
Contributor

shino commented Sep 10, 2015

I will do.

@shino
Copy link
Contributor

shino commented Sep 10, 2015

For release note: Add several operator friendly features, fine grained information gathering options, user defined filtering for configuration files and verbose output for failed commands.

@Basho-JIRA
Copy link

For release note: Add several operator friendly features, fine grained information gathering options, user defined filtering for configuration files and verbose output for failed commands.

_[posted via JIRA by Kota Uenishi]_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants