Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorganize cli tools and introduce riak-cs-admin #839

Merged
merged 1 commit into from
May 20, 2014

Conversation

ksauzz
Copy link
Contributor

@ksauzz ksauzz commented Apr 17, 2014

I'm wondering Riak CS provides a administration cli tool like riak-admin and current tool should migrate into it.

This PR was extracted from #826.

@ksauzz ksauzz self-assigned this Apr 18, 2014
@kuenishi kuenishi added this to the 1.5.0 milestone May 7, 2014
@kuenishi
Copy link
Contributor

kuenishi commented May 8, 2014

@ksauzz is this ready-to-pull ?

@ksauzz
Copy link
Contributor Author

ksauzz commented May 8, 2014

@kuenishi Yes. I've waited for review. 😎

@kuenishi
Copy link
Contributor

kuenishi commented May 9, 2014

Would you mind adding tests like riak-admin ?

@kuenishi
Copy link
Contributor

+1 4033143

borshop added a commit that referenced this pull request May 14, 2014
reorganize cli tools and introduce riak-cs-admin

Reviewed-by: kuenishi
@kuenishi
Copy link
Contributor

@ksauzz you should rebase to the latest develop since #848 was merged after this PR had opened.

@ksauzz
Copy link
Contributor Author

ksauzz commented May 14, 2014

@kuenishi Although it's done, make dialyzer on buildbot still failed. He seems to have to run make cleanplt.

@kuenishi
Copy link
Contributor

Could you run make cleanplt , @jaredmorrow ?

@kuenishi
Copy link
Contributor

Note: after #848 merged, pushing any more commits without rebasing to develop or running CI tests will break the plt file in our CI environment. Please rebase to develop, or branch including #848 .

@kuenishi
Copy link
Contributor

+1 4fb0503

borshop added a commit that referenced this pull request May 20, 2014
reorganize cli tools and introduce riak-cs-admin

Reviewed-by: kuenishi
@kuenishi
Copy link
Contributor

@borshop merge

@borshop borshop merged commit 4fb0503 into develop May 20, 2014
@kuenishi kuenishi deleted the feature/reorganize-cli-tools branch May 20, 2014 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants