-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning logs for manifests, siblings, bytes and history #915
Conversation
- many siblings - large size - long history ({UUID, M} pairs)
@@ -432,6 +433,40 @@ gc_deleted_while_writing_manifests(Object, Manifests, Bucket, Key, RcPid) -> | |||
UUIDs = riak_cs_manifest_utils:deleted_while_writing(Manifests), | |||
riak_cs_gc:gc_specific_manifests(UUIDs, Object, Bucket, Key, RcPid). | |||
|
|||
-spec maybe_log_warning(binary(), binary(), riakc_obj:riakc_obj(), [term()]) -> ok. | |||
maybe_log_warning(Bucket, Key, Object, Manifests) -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick, the name of this function seems too general. I prefer this be maybe_warn_manifest_size/4
and in riak_cs_manifest.erl
.
I tested overwriting hundreds times, then I got logs like this per single put:
This is maybe because |
Both |
- get_manfiests - manifests_from_riak_object
@kota Addressed your comments except the last one and pushed commit. Now logs look like these:
|
Ouch, I mentioned wrong Kota-san. Sorry again and again. I wanted to mention @kuenishi 😓 |
…rning Add warning logs for manifests, siblings, bytes and history Reviewed-by: kuenishi
@borshop merge |
Add three kinks of warning logs for potentially bloated manifests.
Original issue is #882.
Each has default value and enabled, but has kill switch
disabled
.