Add script to repair invalid gc manifests #983
Conversation
|
Still WIP, now debugging... |
shino
force-pushed
the
feature/repair-invalid-gc-manifests
branch
from
3d39c4c
to
4ed9b7c
Compare
shino
force-pushed
the
feature/repair-invalid-gc-manifests
branch
from
4ed9b7c
to
df9c7d1
Compare
shino
changed the title
|
I hope this is ready for review. |
|
Fix riak_test Please review with basho/riak_cs_multibag#13 (for |
|
If we use this script in multibag, do we have to run this script in the CS node directly connecting to the Riak cluster where invalid state manifests are in GC bucket? |
| case riakc_pb_socket:start_link(Host, Port) of | ||
| {ok, Pbc} -> | ||
| repair(Pbc, Options), | ||
| timer:sleep(100); |
There was a problem hiding this comment.
I prefer riakc_pb_socket:stop/1 called here, not in the tail of function call chain.
|
Ah, I got it. It doesn't access riak via CS, but directly hits riak. |
| @@ -54,5 +54,5 @@ | |||
|
|
|||
| {deps_ee, [ | |||
| {riak_repl_pb_api,".*",{git,"git@github.com:basho/riak_repl_pb_api.git", {tag, "0.2.5"}}}, | |||
| {riak_cs_multibag,".*",{git,"git@github.com:basho/riak_cs_multibag.git", {tag, "1.5.0"}}} | |||
| {riak_cs_multibag,".*",{git,"git@github.com:basho/riak_cs_multibag.git", {branch, "master"}}} | |||
There was a problem hiding this comment.
Don't forget to update this before code freeze!
Add script to repair invalid gc manifests Reviewed-by: kuenishi
|
@borshop merge |
This PR addresses the remaining part of #827 .
( #964 is another part)
This PR adds a script to repair invalid state manifests in GC bucket when
activeand0o:*bucket) ispending_delete,scheduled_deleteornotfound