Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: storage calc on deleted buckets (porting to 1.5) #996

Merged
merged 2 commits into from
Oct 16, 2014

Conversation

shino
Copy link
Contributor

@shino shino commented Oct 16, 2014

Porting to release/1.5 of #993.

This fixes a bug related to bucket name re-cycle,
storage calc wrongly includes deleted buckets.
An example of steps to reproduce is:

1. Alice creates a bucket foo
2. Alice deletes the bucket foo
3. Bob creates a bucket with the same name foo
4. Bob PUTs an object to the bucket
5. Then storage calc reports the bucket usage to both Alice and Bob

Condition: (A AND (B-1 OR B-2))

A. a user deletes a bucket and another user creates a bucket with the same name.

B-1. recycle of the bucket name is occured in leeway seconds (default: 1 day)
B-2. some nodes in cluster are down before another change to the user occures.

Conflicts:
	src/riak_cs_storage.erl
@shino shino added this to the 1.5.2 milestone Oct 16, 2014
@shino shino added the Bug label Oct 16, 2014
borshop added a commit that referenced this pull request Oct 16, 2014
…kets-1.5

Bugfix: storage calc on deleted buckets (porting to 1.5)

Reviewed-by: kuenishi
@kuenishi
Copy link
Contributor

@borshop merge

@borshop borshop merged commit f087df9 into release/1.5 Oct 16, 2014
@kuenishi kuenishi deleted the bugfix/storage-calc-on-deleted-buckets-1.5 branch October 16, 2014 08:17
@shino shino modified the milestones: 1.5.3, 1.5.2 Oct 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants