Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regression #515

Merged
merged 3 commits into from
Jun 25, 2015
Merged

fix regression #515

merged 3 commits into from
Jun 25, 2015

Conversation

zeeshanlakhani
Copy link
Contributor

This will fix/handle failing tests

  • yz_index_admin
  • yz_schema_admin

@zeeshanlakhani zeeshanlakhani force-pushed the zl/bugfix/fix-regression-yz_schema_admin branch from 738ef3e to ccff826 Compare June 25, 2015 19:21
@fadushin
Copy link
Contributor

Lowers the timeout to 45 secs on server side, and includes the same behavior as in the pb server for recognizing a timeout configured in advanced config.

+1 ccff826

@zeeshanlakhani zeeshanlakhani force-pushed the zl/bugfix/fix-regression-yz_schema_admin branch from ccff826 to 9f366f1 Compare June 25, 2015 19:47
@zeeshanlakhani zeeshanlakhani force-pushed the zl/bugfix/fix-regression-yz_schema_admin branch from 9f366f1 to c903f78 Compare June 25, 2015 20:18
@cmeiklejohn cmeiklejohn self-assigned this Jun 25, 2015
@cmeiklejohn
Copy link
Contributor

yz_index_admin is still failing for me.

17:06:06.011 [warning] yz_index_admin failed: {{badmatch,{error,req_timedout}},[{yz_index_admin,confirm_create_index_bad_schema,1,[{file,"riak_test/yz_index_admin.erl"},{line,238}]},{yz_index_admin,confirm,0,[{file,"riak_test/yz_index_admin.erl"},{line,145}]},{riak_test_runner,return_to_exit,3,[{file,"src/riak_test_runner.erl"},{line,159}]}]}

@cmeiklejohn
Copy link
Contributor

Recloned, rebuild yokozuna with this branch, rebuilt devrel and this still fails.

@zeeshanlakhani
Copy link
Contributor Author

Hmm. @fadushin and I get this to pass continuously. It still may be a race. Change https://github.com/basho/yokozuna/pull/515/files#diff-1a3790bb249991466837d81c6fa805d1L133 to the original default, 30000, and let me know.

@cmeiklejohn
Copy link
Contributor

👍 c903f78

borshop added a commit that referenced this pull request Jun 25, 2015
…_admin

fix regression and and up timeout b/c default timeout went up

Reviewed-by: cmeiklejohn
@zeeshanlakhani zeeshanlakhani changed the title fix regression and and up timeout b/c default timeout went up fix regression Jun 25, 2015
@zeeshanlakhani
Copy link
Contributor Author

@borshop merge

1 similar comment
@cmeiklejohn
Copy link
Contributor

@borshop merge

@borshop borshop merged commit c903f78 into 2.0 Jun 25, 2015
@cmeiklejohn cmeiklejohn deleted the zl/bugfix/fix-regression-yz_schema_admin branch June 25, 2015 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants