Straighten security #751
Merged
Straighten security #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XML External Entity attack
1. if HTTP API is exposed:
- read any file on the system — via /search/extract, the error message leaks
file content;
- send HTTP «GET /» request to any host — by PUT/POSTing text/xml document,
or via /search/extract. This is also likely riak DoS if the host is
attacker-controlled.
2. if PB API is exposed
- send HTTP «GET /» request to any host — by PUT/POST, see above.
Example request:
<?xml version="1.0"?>
<!DOCTYPE meow [
<!ENTITY xxe2 SYSTEM "/etc/passwd">
<!ENTITY xxe1 SYSTEM "http://host/ping-me">
]>
<meow>&xxe1;</meow>
It doesn't check user-provided path in any way. This allows overriding any file on the system with riak permissions.
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for the details