Ensure defn metadata are always preserved as a map
#1187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisrink10
reviewed
Dec 19, 2024
ikappaki
force-pushed
the
issue/defn-macroexpand-attr-map
branch
from
3b4c9da to
272f772
Compare
ikappaki
changed the title
loop to merge attr-map? and meta in defndefn metadata are always preserved as a map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
can you please review patch to merge the
attr-map?and the metadata indefnusing alooprather thanconj. It addresses #1186.The previous
conjoperation was return in a list rather than a map. This also appears to be the likely cause why the:decoratorsmeta key didn't work when passed in asdefnmetadata indefasync.I've updated the test suite for the same.
Thanks