Fix issue with test/is in macros may not gen detailed info on fail
#830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikappaki
force-pushed
the
issue/test-is-=-macros-dispatch
branch
from
b099837 to
f8691e2
Compare
chrisrink10
reviewed
Jan 23, 2024
| (fn [expr _ _] | ||
| (cond | ||
| (list? expr) (first expr) | ||
| (and (sequential? expr) (not (vector? expr))) (symbol (name (first expr))) |
There was a problem hiding this comment.
This line made the assumption that (first expr) is always a symbol, which seemed dangerous to me. While investigating, I ended up fixing it and incorporating the fix into #831 (which also includes thrown-with-msg? assertion).
There was a problem hiding this comment.
Thanks for looking into it in detail!
|
Improved fix by #831 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
could you please consider fix to fix na issue with
(basilisp.core/is (= ...)not dispatching correctly when(= ..)is a seq. It fixes #829.This issue manifests itself in macros where an the
(= ..)in`(is (= ...))form is expanded to a seq rather than a list, which should be treated accordingly by the = dispatch fn.Thanks