Warn at compile time on arity mismatch for function invocation #842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisrink10
force-pushed
the
feature/compile-time-arity-warnings
branch
from
5316647 to
d3cb1ee
Compare
chrisrink10
force-pushed
the
feature/compile-time-arity-warnings
branch
from
9dff082 to
87719bf
Compare
chrisrink10
commented
Jan 29, 2024
| @@ -43,3 +50,13 @@ | |||
| PyCollectionForm = Union[dict, list, set, tuple] | |||
| ReaderForm = Union[LispForm, IRecord, ISeq, IType, PyCollectionForm] | |||
| SpecialForm = Union[llist.PersistentList, ISeq] | |||
|
|
|||
|
|
|||
| class BasilispFunction(Protocol): | |||
There was a problem hiding this comment.
Technically also IWithMeta but MyPy does not allow Protocols to inherit from non-Protocols and I don't want to mess with trying to change IWithMeta to a Protocol type now.
| @@ -30,7 +30,7 @@ def pytest_collect_file(file_path: Path, path, parent): | |||
| """Primary PyTest hook to identify Basilisp test files.""" | |||
| if file_path.suffix == ".lpy": | |||
| if file_path.name.startswith("test_") or file_path.stem.endswith("_test"): | |||
| return BasilispFile.from_parent(parent, fspath=path, path=file_path) | |||
There was a problem hiding this comment.
This was constantly hitting us with deprecation warnings on test runs.
| @@ -3223,7 +3231,6 @@ def _interop_prop_to_py_ast( | |||
| assert node.op == NodeOp.HOST_FIELD | |||
|
|
|||
| target_ast = gen_py_ast(ctx, node.target) | |||
| assert not target_ast.dependencies | |||
There was a problem hiding this comment.
Not sure why this was here. The dependencies are passed on a couple lines down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a compile-time warning for arity mismatches on function invocations. The warning is enabled by default (if the dev logger is enabled and configured for at least
WARNINGlevel logs).In order to facilitate this work, we also had to change the computation of the Basilisp function
aritiesattribute set. Previously this included only fixed arities (the argument count for each non-variadic function arity) and a:restkeyword if the function included a variadic arity. Nowaritieswill include all fixed arities including the number of fixed (non-variadic) arguments to the varidic arity. This allows for more sophisticated warnings.As part of this bill of work, it was also required to update
partialto support computing a new set ofaritiesfor partial applications.functools.wrapscopies all values from__dict__to wrapped functions, so partials were appearing to have the same set of arities as their wrapped function which was never correct.Fixes #671
Fixes #847