Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aws-profile and aws-region flags #30

Merged
merged 2 commits into from
Apr 22, 2023

Conversation

BohdanPetryshyn
Copy link
Collaborator

@BohdanPetryshyn BohdanPetryshyn commented Apr 22, 2023

Summary

This PR adds two new CLI options:

  1. --aws-profile - Indicates an AWS CLI profile to use
  2. --aws-region - Indicates an AWS region to use

The PR also makes commands being imported dynamically. This improves application startup time:

  • basti -h before: ~1.4s
  • basti -h after: ~0.5s

This improvement compensates for the increased complexity of the AwsClients initialization and application initialization in general.

References

closes #12
closes #15

@BohdanPetryshyn BohdanPetryshyn merged commit 5442b48 into main Apr 22, 2023
@BohdanPetryshyn BohdanPetryshyn deleted the feat/aws-profile-and-region-flags branch April 22, 2023 05:35
Copy link
Contributor

@motnyk motnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dynamic imports FTW 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --region command option Add --aws-profile command option
2 participants