fix(deps): declare our dependency on bazel_skylib #1001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#846 introduced this dependency, and solved the broken examples by installing the dependency only for our own code. However, this was an inintentional breaking change for users, who may not have had bazel_skylib installed in their workspace. This effectively reverts #370. At that time we didn't want any dependencies, because managing them under Bazel's WORKSPACE semantics is so difficult for users. Now that bzlmod has reached General Availability in Bazel 6, such dependencies can be managed more easily. This also allows us to introduce bzl_library calls in our BUILD files, making it less brittle to ensure that users can generate docs for their rules/macros which load from rules_python.
f0rmiga
approved these changes
Jan 21, 2023
alexeagle
added a commit
that referenced
this pull request
Jan 21, 2023
Following #1001 we require that users install bazel-skylib, so we are now free to load from it.
alexeagle
added a commit
that referenced
this pull request
Jan 21, 2023
Following #1001 we require that users install bazel-skylib, so we are now free to load from it.
f0rmiga
pushed a commit
that referenced
this pull request
Jan 23, 2023
Following #1001 we require that users install bazel-skylib, so we are now free to load from it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#846 introduced this dependency, and solved the broken examples by installing the dependency only for our own code. However, this was an unintentional breaking change for users, who may not have had bazel_skylib installed in their workspace.
(Note for reviewers, any change to the examples is an indication that it will be breaking to users, as it represents changes required for using the rules)
This effectively reverts #370. At that time we didn't want any dependencies, because managing them under Bazel's WORKSPACE semantics is so difficult for users. Now that bzlmod has reached General Availability in Bazel 6, such dependencies can be managed more easily.
This also allows us to introduce bzl_library calls in our BUILD files, making it less brittle to ensure that users can generate docs for their rules/macros which load from rules_python.