Redirect stdout when checking imports. #1007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return "" | ||
|
|
||
|
|
||
| site.getusersitepackages = __override_getusersitepackages__ |
There was a problem hiding this comment.
This code wasn't having the desired effect.
Fixes bazel-contrib#1006 Also, set PYTHONNOUSERSITE so that the script doesn't even look in site packages when checking modules. Fix typo with capitilize.
aptenodytes-forsteri
force-pushed
the
1006-fix-gazelle-crash
branch
from
cf8c3cb to
f7e1e31
Compare
|
I might be able to add a test case |
Scratch that, looks a bit more involved. Probably enough of an edge case here that it doesn't really need to be covered by a test. |
f0rmiga
approved these changes
Jan 23, 2023
| for module in stdin: | ||
| module = module.strip() | ||
| # Don't print the boolean directly as it is captilized in Python. | ||
| # Don't print the boolean directly as it is capitalized in Python. |
There was a problem hiding this comment.
This was the Brazilian spelling. 🤣
Thanks for fixing it.
| return "" | ||
|
|
||
|
|
||
| site.getusersitepackages = __override_getusersitepackages__ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1006
Also, set PYTHONNOUSERSITE so that the script doesn't even look in site packages when checking modules.
Fix typo with capitilize.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1006
What is the new behavior?
No extraneous output.
Does this PR introduce a breaking change?
Other information