Skip to content

tests: Move base rule tests under tests instead of //tools/build_defs/python #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2023
Merged

tests: Move base rule tests under tests instead of //tools/build_defs/python #1440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 tools/build_defs/python/tests/BUILD.bazel → tests/base_rules/BUILD.bazel
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions tools/build_defs/python/tests/base_tests.bzl → tests/base_rules/base_tests.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ load("@rules_testing//lib:analysis_test.bzl", "analysis_test")
load("@rules_testing//lib:truth.bzl", "matching")
load("@rules_testing//lib:util.bzl", "PREVENT_IMPLICIT_BUILDING_TAGS", rt_util = "util")
load("//python:defs.bzl", "PyInfo")
load("//tools/build_defs/python/tests:py_info_subject.bzl", "py_info_subject")
load("//tools/build_defs/python/tests:util.bzl", pt_util = "util")
load("//tests/base_rules:py_info_subject.bzl", "py_info_subject")
load("//tests/base_rules:util.bzl", pt_util = "util")

_tests = []

Expand Down
0 ...d_defs/python/tests/py_binary/BUILD.bazel → tests/base_rules/py_binary/BUILD.bazel
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...ython/tests/py_binary/py_binary_tests.bzl → .../base_rules/py_binary/py_binary_tests.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

load("//python:defs.bzl", "py_binary")
load(
"//tools/build_defs/python/tests:py_executable_base_tests.bzl",
"//tests/base_rules:py_executable_base_tests.bzl",
"create_executable_tests",
)

Expand Down
4 changes: 2 additions & 2 deletions ...python/tests/py_executable_base_tests.bzl → ...s/base_rules/py_executable_base_tests.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
load("@rules_testing//lib:analysis_test.bzl", "analysis_test")
load("@rules_testing//lib:truth.bzl", "matching")
load("@rules_testing//lib:util.bzl", rt_util = "util")
load("//tools/build_defs/python/tests:base_tests.bzl", "create_base_tests")
load("//tools/build_defs/python/tests:util.bzl", "WINDOWS_ATTR", pt_util = "util")
load("//tests/base_rules:base_tests.bzl", "create_base_tests")
load("//tests/base_rules:util.bzl", "WINDOWS_ATTR", pt_util = "util")

_tests = []

Expand Down
0 ...ild_defs/python/tests/py_info_subject.bzl → tests/base_rules/py_info_subject.bzl
View file
Open in desktop
File renamed without changes.
0 ..._defs/python/tests/py_library/BUILD.bazel → tests/base_rules/py_library/BUILD.bazel
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions ...hon/tests/py_library/py_library_tests.bzl → ...ase_rules/py_library/py_library_tests.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ load("@rules_testing//lib:analysis_test.bzl", "analysis_test")
load("@rules_testing//lib:truth.bzl", "matching")
load("@rules_testing//lib:util.bzl", rt_util = "util")
load("//python:defs.bzl", "PyRuntimeInfo", "py_library")
load("//tools/build_defs/python/tests:base_tests.bzl", "create_base_tests")
load("//tools/build_defs/python/tests:util.bzl", pt_util = "util")
load("//tests/base_rules:base_tests.bzl", "create_base_tests")
load("//tests/base_rules:util.bzl", pt_util = "util")

_tests = []

Expand Down
0 ...ild_defs/python/tests/py_test/BUILD.bazel → tests/base_rules/py_test/BUILD.bazel
View file
Open in desktop
File renamed without changes.
8 changes: 4 additions & 4 deletions ...fs/python/tests/py_test/py_test_tests.bzl → tests/base_rules/py_test/py_test_tests.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,17 @@ load("@rules_testing//lib:analysis_test.bzl", "analysis_test")
load("@rules_testing//lib:util.bzl", rt_util = "util")
load("//python:defs.bzl", "py_test")
load(
"//tools/build_defs/python/tests:py_executable_base_tests.bzl",
"//tests/base_rules:py_executable_base_tests.bzl",
"create_executable_tests",
)
load("//tools/build_defs/python/tests:util.bzl", pt_util = "util")
load("//tests/base_rules:util.bzl", pt_util = "util")

# Explicit Label() calls are required so that it resolves in @rules_python context instead of
# @rules_testing context.
_FAKE_CC_TOOLCHAIN = Label("//tests/cc:cc_toolchain_suite")
_FAKE_CC_TOOLCHAINS = [str(Label("//tests/cc:all"))]
_PLATFORM_MAC = Label("//tools/build_defs/python/tests:mac")
_PLATFORM_LINUX = Label("//tools/build_defs/python/tests:linux")
_PLATFORM_MAC = Label("//tests/base_rules:mac")
_PLATFORM_LINUX = Label("//tests/base_rules:linux")

_tests = []

Expand Down
0 tools/build_defs/python/tests/util.bzl → tests/base_rules/util.bzl
View file
Open in desktop
File renamed without changes.
0 ...ld_defs/python/tests/py_wheel/BUILD.bazel → tests/py_wheel/py_wheel/BUILD.bazel
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion .../python/tests/py_wheel/py_wheel_tests.bzl → tests/py_wheel/py_wheel/py_wheel_tests.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ load("@rules_testing//lib:analysis_test.bzl", "analysis_test")
load("@rules_testing//lib:truth.bzl", "matching")
load("@rules_testing//lib:util.bzl", rt_util = "util")
load("//python:packaging.bzl", "py_wheel")
load("//tools/build_defs/python/tests:util.bzl", pt_util = "util")
load("//tests/base_rules:util.bzl", pt_util = "util")

_tests = []

Expand Down