internal(pystar): use rules_python PyCcLinkParamsProvider if pystar is enabled #1517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nabled The PyCcLinkParamsInfo export wasn't respecting the `config.enable_pystar` setting. Work towards bazel-contrib#1069
rickeylev
force-pushed
the
pystar-cclinkparams
branch
from
4fb4faf to
daea615
Compare
Solumin
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PyCcLinkParamsInfo export wasn't respecting the
config.enable_pystarsetting. Thiswould cause the Starlark implementation to look up the wrong provider symbol and result
in an error later.
Work towards #1069