refactor: move python/repositories.bzl implementation under python/private #2083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aignas
reviewed
Jul 22, 2024
| # These symbols are of questionable public visibility. They were probably | ||
| # not intended to be actually public. | ||
| STANDALONE_INTERPRETER_FILENAME = _STANDALONE_INTERPRETER_FILENAME | ||
| http_archive = _http_archive |
There was a problem hiding this comment.
Pretty sure we can remove this, but I'm fine with being incremental here.
aignas
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly for consistency with other code, but in doing so, it looks like there
are several symbols that have public visibility that probably weren't meant to be
public. Cleaning that up is left for another PR in the future.