Skip to content

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented Aug 1, 2024

This PR uses the flag_values from the platform definitions
for the toolchains so that in the future we can distinguish
between musl and glibc toolchains in our tests.

For now the change is no-op.

As part of this change we are also registering the coverage
tools so that we can run bazel coverage with no errors.

See comment on #2095.

@aignas aignas changed the title test(toolchain): use flag_values in test platform defs test(toolchain): use flag_values in test platform defs and register coverage Aug 1, 2024
@aignas aignas requested a review from groodt August 1, 2024 18:57
Copy link
Collaborator

@rickeylev rickeylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the description to better describe the change? A PR/issue number is nice, but I prefer commits to be more self-descriptive.

@aignas aignas changed the title test(toolchain): use flag_values in test platform defs and register coverage test(toolchain): use flag_values in test platform defs Aug 2, 2024
@aignas aignas enabled auto-merge August 2, 2024 08:28
@aignas aignas added this pull request to the merge queue Aug 2, 2024
Merged via the queue into bazel-contrib:main with commit fa13b01 Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants