Skip to content

fix: formatting directive bugs in test #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2024
Merged

fix: formatting directive bugs in test #2134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f109c6
fix: t.Fatal/t.Fatalf typo
tokongs Aug 20, 2024
26f902e
Update CHANGELOG.md
tokongs Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ A brief description of the categories of changes:
### Changed
* Nothing yet

### Fixed
* (gazelle): Fix incorrect use of `t.Fatal`/`t.Fatalf` in tests.

### Added
* Nothing yet

Expand Down
6 changes: 3 additions & 3 deletions gazelle/manifest/test/test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@ import (
func TestGazelleManifestIsUpdated(t *testing.T) {
requirementsPath := os.Getenv("_TEST_REQUIREMENTS")
if requirementsPath == "" {
t.Fatalf("_TEST_REQUIREMENTS must be set")
t.Fatal("_TEST_REQUIREMENTS must be set")
}

manifestPath := os.Getenv("_TEST_MANIFEST")
if manifestPath == "" {
t.Fatalf("_TEST_MANIFEST must be set")
t.Fatal("_TEST_MANIFEST must be set")
}

manifestFile := new(manifest.File)
Expand All @@ -53,7 +53,7 @@ func TestGazelleManifestIsUpdated(t *testing.T) {
manifestGeneratorHashPath, err := runfiles.Rlocation(
os.Getenv("_TEST_MANIFEST_GENERATOR_HASH"))
if err != nil {
t.Fatal("failed to resolve runfiles path of manifest: %v", err)
t.Fatalf("failed to resolve runfiles path of manifest: %v", err)
}

manifestGeneratorHash, err := os.Open(manifestGeneratorHashPath)
Expand Down