Skip to content

tests: don't restrict python versions in bzlmod example #2362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2024
Merged

tests: don't restrict python versions in bzlmod example #2362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a877ef7
tests: dont restrict python versions in bzlmod example
rickeylev Oct 30, 2024
daab629
fixup! tests: dont restrict python versions in bzlmod example
rickeylev Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions examples/bzlmod/MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,16 @@ python.toolchain(
# One can override the actual toolchain versions that are available, which can be useful
# when optimizing what gets downloaded and when.
python.override(
available_python_versions = [
"3.10.9",
"3.9.18",
"3.9.19",
# The following is used by the `other_module` and we need to include it here
# as well.
"3.11.8",
],
# NOTE: These are disabled in the example because transitive dependencies
# require versions not listed here.
# available_python_versions = [
# "3.10.9",
# "3.9.18",
# "3.9.19",
# # The following is used by the `other_module` and we need to include it here
# # as well.
# "3.11.8",
# ],
# Also override the `minor_mapping` so that the root module,
# instead of rules_python's defaulting to the latest available version,
# controls what full version is used when `3.x` is requested.
Expand Down