-
-
Notifications
You must be signed in to change notification settings - Fork 631
docs: update changelog for config_settings attribute #3257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update changelog for config_settings attribute #3257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily updates the project's changelog to reflect the introduction of the config_settings attribute for Python rules, enhancing build graph control. Additionally, it includes a fix for a typo in a documentation guide's filename, ensuring correct referencing and accessibility.
Highlights
- Changelog Update for config_settings: The CHANGELOG.md file has been updated to include the new config_settings attribute for py_binary, py_test, and py_wheel rules. It also notes how to add custom settings using config.add_transition_setting in MODULE.bazel and py_repositories(transition_settings=...) in WORKSPACE files.
- Documentation Filename Correction: A typo in the filename docs/howto/common-deps-with-multipe-pypi-versions.md has been corrected to docs/howto/common-deps-with-multiple-pypi-versions.md. A reference label (common-deps-with-multiple-pypi-versions)= was also added to the top of this guide.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on updating the project's documentation. It adds new entries to the changelog to reflect recent changes regarding the config_settings attribute in Python rules and corrects a typo in an existing documentation filename, ensuring accurate referencing.
Highlights
- Changelog Update for config_settings: The CHANGELOG.md file has been updated to include the new config_settings attribute for py_binary, py_test, and py_wheel rules, along with details on how to use config.add_transition_setting and py_repositories(transition_settings=...).
- Documentation Filename Correction: A typo in the filename docs/howto/common-deps-with-multipe-pypi-versions.md has been corrected to docs/howto/common-deps-with-multiple-pypi-versions.md, and a new reference label (common-deps-with-multiple-pypi-versions)= has been added to the file.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the changelog to include information about the new config_settings
attribute and its related APIs for bzlmod and WORKSPACE. It also fixes a typo in a filename for one of the documentation guides and adds the necessary label for cross-referencing. The changes are good, but I found a small typo in an environment variable name in the changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the changelog with information about the new config_settings
attribute and fixes a filename for a documentation guide. I've found a couple of minor issues: a typo in an environment variable name and a malformed Sphinx reference in the changelog. My review includes suggestions to fix these.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Add the config_settings and bzlmod/workspace apis to changelog.
Along the way, fix the filename for the common deps with pypi guide.