fix: ensure the stage1 bootstrap is executable

[EdSchouten]

Bazel tends to make files executable, even if ctx.actions.write() or ctx.actions.expand_template() is called without is_executable = True. However, in an analysis tool of mine that is a bit more pedantic than Bazel this leads to the issue that py_binary() targets can't be executed due to them not having a +x bit.

Considering that the stage2 bootstrap is marked executable, let's mark is_executable for consistency.

[gemini-code-assist]

Summary of Changes

Hello @EdSchouten, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the stage1 bootstrap script was not consistently marked as executable, which could prevent certain analysis tools from running "py_binary()" targets. The change ensures that the script is always executable, improving compatibility and reliability across different environments.

Highlights

• Ensure stage1 bootstrap executability: Explicitly sets "is_executable = True" when creating the stage1 bootstrap script to ensure it has execute permissions, addressing an issue where "py_binary()" targets could not be executed by certain analysis tools.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an issue where the stage1 bootstrap script for Python executables might not have the executable bit set, causing issues in certain environments. The fix involves adding is_executable = True to the expand_template action that generates this script. This change aligns the stage1 bootstrap with the stage2 bootstrap, improving consistency and ensuring the generated executable is always runnable. The change is correct and well-justified.

[rickeylev]

Thanks for the fix!